From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by kanga.kvack.org (Postfix) with ESMTP id 970856B0038 for ; Fri, 10 Jul 2015 10:19:17 -0400 (EDT) Received: by iebmu5 with SMTP id mu5so196702975ieb.1 for ; Fri, 10 Jul 2015 07:19:17 -0700 (PDT) Received: from resqmta-ch2-04v.sys.comcast.net (resqmta-ch2-04v.sys.comcast.net. [69.252.207.36]) by mx.google.com with ESMTPS id s9si1522621ign.77.2015.07.10.07.19.13 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 10 Jul 2015 07:19:15 -0700 (PDT) Date: Fri, 10 Jul 2015 09:19:11 -0500 (CDT) From: Christoph Lameter Subject: Re: [patch] mm/slub: Move slab initialization into irq enabled region In-Reply-To: <20150710120259.836414367@linutronix.de> Message-ID: References: <20150710120259.836414367@linutronix.de> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Thomas Gleixner Cc: LKML , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , linux-mm@kvack.org, Sebastian Andrzej Siewior , Steven Rostedt , Peter Zijlstra There is a duplicate check for page == NULL now. Subject: slub: allocate_slab: no need to check twice for page == NULL Remove the second check. Signed-off-by: Christoph Lameter Index: linux/mm/slub.c =================================================================== --- linux.orig/mm/slub.c +++ linux/mm/slub.c @@ -1396,9 +1396,6 @@ static struct page *allocate_slab(struct kmemcheck_mark_unallocated_pages(page, pages); } - if (!page) - goto out; - page->objects = oo_objects(oo); order = compound_order(page); -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org