From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qa0-f44.google.com (mail-qa0-f44.google.com [209.85.216.44]) by kanga.kvack.org (Postfix) with ESMTP id D171B900015 for ; Fri, 13 Feb 2015 19:16:54 -0500 (EST) Received: by mail-qa0-f44.google.com with SMTP id n8so14856404qaq.3 for ; Fri, 13 Feb 2015 16:16:54 -0800 (PST) Received: from resqmta-ch2-10v.sys.comcast.net ([2001:558:fe21:29:250:56ff:feaf:60fe]) by mx.google.com with ESMTPS id c13si4752979qaw.34.2015.02.13.16.16.53 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 13 Feb 2015 16:16:54 -0800 (PST) Date: Fri, 13 Feb 2015 18:16:52 -0600 (CST) From: Christoph Lameter Subject: Re: [PATCH 3/3] mm: slub: Add SLAB_DEBUG_CRASH option In-Reply-To: <54DE8E47.5040800@canonical.com> Message-ID: References: <1423865980-10417-1-git-send-email-chris.j.arges@canonical.com> <1423865980-10417-3-git-send-email-chris.j.arges@canonical.com> <54DE8E47.5040800@canonical.com> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Chris J Arges Cc: David Rientjes , linux-kernel@vger.kernel.org, Jonathan Corbet , Pekka Enberg , Joonsoo Kim , Andrew Morton , linux-doc@vger.kernel.org, linux-mm@kvack.org On Fri, 13 Feb 2015, Chris J Arges wrote: > The diff doesn't show this clearly, but the BUG_ON was added to both > free_debug_processing and alloc_debug_processing. This is not good. There should be no BUG_ON. The problem report by the allocator already includes a backtrace. You need to abort with the crash dump. Maybe print a message describing what is going on before. Crash dump and abort would make most sense in slab_err() and object_err(). -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org