From: Christoph Lameter <cl@linux.com>
To: Chris J Arges <chris.j.arges@canonical.com>
Cc: David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-doc@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/3] mm: slub: Add SLAB_DEBUG_CRASH option
Date: Fri, 13 Feb 2015 18:16:52 -0600 (CST) [thread overview]
Message-ID: <alpine.DEB.2.11.1502131810520.14741@gentwo.org> (raw)
In-Reply-To: <54DE8E47.5040800@canonical.com>
On Fri, 13 Feb 2015, Chris J Arges wrote:
> The diff doesn't show this clearly, but the BUG_ON was added to both
> free_debug_processing and alloc_debug_processing.
This is not good. There should be no BUG_ON. The problem report by the
allocator already includes a backtrace. You need to abort with the crash
dump. Maybe print a message describing what is going on before.
Crash dump and abort would make most sense in slab_err() and object_err().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-02-14 0:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1423865980-10417-1-git-send-email-chris.j.arges@canonical.com>
2015-02-13 22:19 ` [PATCH 2/3] mm: slub: parse slub_debug O option in switch statement Chris J Arges
2015-02-13 23:36 ` David Rientjes
2015-02-13 22:19 ` [PATCH 3/3] mm: slub: Add SLAB_DEBUG_CRASH option Chris J Arges
2015-02-13 23:38 ` David Rientjes
2015-02-13 23:52 ` Chris J Arges
2015-02-14 0:16 ` Christoph Lameter [this message]
2015-02-14 22:32 ` [PATCH v2] " Chris J Arges
2015-02-13 23:58 ` [PATCH 3/3] " Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1502131810520.14741@gentwo.org \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=chris.j.arges@canonical.com \
--cc=corbet@lwn.net \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox