linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Markos Chandras <Markos.Chandras@imgtec.com>,
	linux-mips@linux-mips.org
Subject: Re: [PATCH for v3.18] mm/slab: fix unalignment problem on Malta with EVA due to slab merge
Date: Fri, 31 Oct 2014 10:17:16 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.2.11.1410311015490.14859@gentwo.org> (raw)
In-Reply-To: <1414742912-14852-1-git-send-email-iamjoonsoo.kim@lge.com>

On Fri, 31 Oct 2014, Joonsoo Kim wrote:

> alloc_unbound_pwq() allocates slab object from pool_workqueue. This
> kmem_cache requires 256 bytes alignment, but, current merging code
> doesn't honor that, and merge it with kmalloc-256. kmalloc-256 requires
> only cacheline size alignment so that above failure occurs. However,
> in x86, kmalloc-256 is luckily aligned in 256 bytes, so the problem
> didn't happen on it.

That luck will run out when you enable debugging. But then that also
usually means disablign merging.

> To fix this problem, this patch introduces alignment mismatch check
> in find_mergeable(). This will fix the problem.

Acked-by: Christoph Lameter <cl@linux.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2014-10-31 15:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31  8:08 Joonsoo Kim
2014-10-31 15:17 ` Christoph Lameter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1410311015490.14859@gentwo.org \
    --to=cl@linux.com \
    --cc=Markos.Chandras@imgtec.com \
    --cc=akpm@linux-foundation.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox