From: Christoph Lameter <cl@linux.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mm/slab: use percpu allocator for cpu cache
Date: Wed, 27 Aug 2014 18:37:33 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.11.1408271827010.26560@gentwo.org> (raw)
In-Reply-To: <1408608675-20420-1-git-send-email-iamjoonsoo.kim@lge.com>
One minor nit. Otherwise
Acked-by: Christoph Lameter <cl@linux.com>
On Thu, 21 Aug 2014, Joonsoo Kim wrote:
> @@ -2041,56 +1982,63 @@ static size_t calculate_slab_order(struct kmem_cache *cachep,
> return left_over;
> }
>
> +static int alloc_kmem_cache_cpus(struct kmem_cache *cachep, int entries,
> + int batchcount)
> +{
> + cachep->cpu_cache = __alloc_kmem_cache_cpus(cachep, entries,
> + batchcount);
> + if (!cachep->cpu_cache)
> + return 1;
> +
> + return 0;
> +}
Do we really need this trivial function? It doesnt do anything useful as
far as I can tell.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-08-27 23:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-21 8:11 Joonsoo Kim
2014-08-21 8:11 ` [PATCH 2/3] mm/slab_common: commonize slab merge logic Joonsoo Kim
2014-08-21 14:22 ` Christoph Lameter
2014-08-25 8:26 ` Joonsoo Kim
2014-08-25 15:27 ` Christoph Lameter
2014-08-26 2:23 ` Joonsoo Kim
2014-08-26 21:23 ` Christoph Lameter
2014-08-21 8:11 ` [PATCH 3/3] mm/slab: support slab merge Joonsoo Kim
2014-08-25 15:29 ` Christoph Lameter
2014-08-26 2:26 ` Joonsoo Kim
2014-08-21 14:21 ` [PATCH 1/3] mm/slab: use percpu allocator for cpu cache Christoph Lameter
2014-08-25 8:26 ` Joonsoo Kim
2014-08-25 13:13 ` Christoph Lameter
2014-08-26 2:19 ` Joonsoo Kim
2014-08-26 21:22 ` Christoph Lameter
2014-08-27 23:37 ` Christoph Lameter [this message]
2014-09-01 0:19 ` Joonsoo Kim
2014-09-28 6:24 ` [REGRESSION] " Jeremiah Mahler
2014-09-28 16:38 ` Christoph Lameter
2014-09-29 7:44 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1408271827010.26560@gentwo.org \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox