From: Christoph Lameter <cl@gentwo.org>
To: Wei Yang <weiyang@linux.vnet.ibm.com>
Cc: David Rientjes <rientjes@google.com>,
Sasha Levin <sasha.levin@oracle.com>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Dave Jones <davej@redhat.com>
Subject: Re: mm: slub: invalid memory access in setup_object
Date: Wed, 2 Jul 2014 09:20:20 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.11.1407020918130.17773@gentwo.org> (raw)
In-Reply-To: <20140702020454.GA6961@richard>
On Wed, 2 Jul 2014, Wei Yang wrote:
> My patch is somewhat convoluted since I wanted to preserve the original logic
> and make minimal change. And yes, it looks not that nice to audience.
Well I was the author of the initial "convoluted" logic.
> I feel a little hurt by this patch. What I found and worked is gone with this
> patch.
Ok how about giving this one additional revision. Maybe you can make the
function even easier to read? F.e. the setting of the NULL pointer at the
end of the loop is ugly.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-07-02 14:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 16:51 Sasha Levin
2014-06-25 17:30 ` Christoph Lameter
2014-06-30 22:03 ` David Rientjes
2014-07-01 1:40 ` Wei Yang
2014-07-01 14:58 ` Christoph Lameter
2014-07-01 21:49 ` Andrew Morton
2014-07-01 21:52 ` Sasha Levin
2014-07-02 14:44 ` Christoph Lameter
2014-07-02 2:06 ` Wei Yang
2014-07-02 15:07 ` Christoph Lameter
2014-07-03 2:23 ` Wei Yang
2014-07-02 2:04 ` Wei Yang
2014-07-02 14:20 ` Christoph Lameter [this message]
2014-07-03 12:40 ` Wei Yang
2014-07-07 13:51 ` Christoph Lameter
2014-07-08 1:34 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1407020918130.17773@gentwo.org \
--to=cl@gentwo.org \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=sasha.levin@oracle.com \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox