From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f200.google.com (mail-io0-f200.google.com [209.85.223.200]) by kanga.kvack.org (Postfix) with ESMTP id A57666B0038 for ; Mon, 30 Oct 2017 17:36:42 -0400 (EDT) Received: by mail-io0-f200.google.com with SMTP id n79so37411385ion.17 for ; Mon, 30 Oct 2017 14:36:42 -0700 (PDT) Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id b140sor7715703iob.273.2017.10.30.14.36.41 for (Google Transport Security); Mon, 30 Oct 2017 14:36:41 -0700 (PDT) Date: Mon, 30 Oct 2017 14:36:39 -0700 (PDT) From: David Rientjes Subject: Re: [RESEND v12 0/6] cgroup-aware OOM killer In-Reply-To: <20171027093107.GA29492@castle.dhcp.TheFacebook.com> Message-ID: References: <20171019185218.12663-1-guro@fb.com> <20171019194534.GA5502@cmpxchg.org> <20171026142445.GA21147@cmpxchg.org> <20171027093107.GA29492@castle.dhcp.TheFacebook.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Roman Gushchin Cc: Johannes Weiner , Andrew Morton , linux-mm@kvack.org, Michal Hocko , Vladimir Davydov , Tetsuo Handa , Tejun Heo , kernel-team@fb.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, 27 Oct 2017, Roman Gushchin wrote: > The thing is that the hierarchical approach (as in v8), which are you pushing, > has it's own limitations, which we've discussed in details earlier. There are > reasons why v12 is different, and we can't really simple go back. I mean if > there are better ideas how to resolve concerns raised in discussions around v8, > let me know, but ignoring them is not an option. > I'm not ignoring them, I have stated that we need the ability to protect important cgroups on the system without oom disabling all attached processes. If that is implemented as a memory.oom_score_adj with the same semantics as /proc/pid/oom_score_adj, i.e. a proportion of available memory (the limit), it can also address the issues pointed out with the hierarchical approach in v8. If this is not the case, could you elaborate on what your exact concern is and why we do not care that users can completely circumvent victim selection by creating child cgroups for other controllers? Since the ability to protect important cgroups on the system may require a heuristic change, I think it should be solved now rather than constantly insisting that we can make this patchset complete later and in the meantime force the user to set all attached processes to be oom disabled. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org