From: David Rientjes <rientjes@google.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
linux-mm@kvack.org, Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Mel Gorman <mgorman@techsingularity.net>,
Michal Hocko <mhocko@kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Rik van Riel <riel@redhat.com>
Subject: Re: [RFC PATCH 0/6] proactive kcompactd
Date: Tue, 22 Aug 2017 13:57:14 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1708221351510.45189@chino.kir.corp.google.com> (raw)
In-Reply-To: <20170821141014.GC1371@cmpxchg.org>
On Mon, 21 Aug 2017, Johannes Weiner wrote:
> > I think I would have liked to have seen "less proactive" :)
> >
> > Kcompactd currently has the problem that it is MIGRATE_SYNC_LIGHT so it
> > continues until it can defragment memory. On a host with 128GB of memory
> > and 100GB of it sitting in a hugetlb pool, we constantly get kcompactd
> > wakeups for order-2 memory allocation. The stats are pretty bad:
> >
> > compact_migrate_scanned 2931254031294
> > compact_free_scanned 102707804816705
> > compact_isolated 1309145254
> >
> > 0.0012% of memory scanned is ever actually isolated. We constantly see
> > very high cpu for compaction_alloc() because kcompactd is almost always
> > running in the background and iterating most memory completely needlessly
> > (define needless as 0.0012% of memory scanned being isolated).
>
> The free page scanner will inevitably wade through mostly used memory,
> but 0.0012% is lower than what systems usually have free. I'm guessing
> this is because of concurrent allocation & free cycles racing with the
> scanner? There could also be an issue with how we do partial scans.
>
More than 90% of this system's memory is in the hugetlbfs pool so the
freeing scanner needlessly scans over it. Because kcompactd does
MIGRATE_SYNC_LIGHT compaction, it doesn't stop iterating until the
allocation is successful at pgdat->kcompactd_max_order or the migration
and freeing scanners meet. This is normally all memory.
Because of MIGRATE_SYNC_LIGHT, kcompactd does respect deferred compaction
and will avoid doing compaction at all for the next
1 << COMPACT_MAX_DEFER_SHIFT wakeups, but while the rest of userspace not
mapping hugetlbfs memory tries to fault thp, this happens almost nonstop
at 100% of cpu.
Although this might not be a typical configuration, it can easily be used
to demonstrate how inefficient kcompactd behaves under load when a small
amount of memory is free or cannot be isolated because its pinned.
vm.extfrag_threshold isn't an adequate solution.
> Anyway, we've also noticed scalability issues with the current scanner
> on 128G and 256G machines. Even with a better efficiency - finding the
> 1% of free memory, that's still a ton of linear search space.
>
Agreed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-08-22 20:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 16:06 Vlastimil Babka
2017-07-27 16:06 ` [PATCH 1/6] mm, kswapd: refactor kswapd_try_to_sleep() Vlastimil Babka
2017-07-28 9:38 ` Mel Gorman
2017-07-27 16:06 ` [PATCH 2/6] mm, kswapd: don't reset kswapd_order prematurely Vlastimil Babka
2017-07-28 10:16 ` Mel Gorman
2017-07-27 16:06 ` [PATCH 3/6] mm, kswapd: reset kswapd's order to 0 when it fails to reclaim enough Vlastimil Babka
2017-07-27 16:06 ` [PATCH 4/6] mm, kswapd: wake up kcompactd when kswapd had too many failures Vlastimil Babka
2017-07-28 10:41 ` Mel Gorman
2017-07-27 16:07 ` [RFC PATCH 5/6] mm, compaction: stop when number of free pages goes below watermark Vlastimil Babka
2017-07-28 10:43 ` Mel Gorman
2017-07-27 16:07 ` [RFC PATCH 6/6] mm: make kcompactd more proactive Vlastimil Babka
2017-07-28 10:58 ` Mel Gorman
2017-08-09 20:58 ` [RFC PATCH 0/6] proactive kcompactd David Rientjes
2017-08-21 14:10 ` Johannes Weiner
2017-08-21 21:40 ` Rik van Riel
2017-08-22 20:57 ` David Rientjes [this message]
2017-08-23 5:36 ` Joonsoo Kim
2017-08-23 8:12 ` Vlastimil Babka
2017-08-24 6:24 ` Joonsoo Kim
2017-08-24 11:30 ` Vlastimil Babka
2017-08-24 23:51 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1708221351510.45189@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=aarcange@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=riel@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox