From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Mel Gorman <mgorman@techsingularity.net>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [patch 1/2] mm, compaction: kcompactd should not ignore pageblock skip
Date: Tue, 15 Aug 2017 16:39:30 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1708151638550.106658@chino.kir.corp.google.com> (raw)
Kcompactd is needlessly ignoring pageblock skip information. It is doing
MIGRATE_SYNC_LIGHT compaction, which is no more powerful than
MIGRATE_SYNC compaction.
If compaction recently failed to isolate memory from a set of pageblocks,
there is nothing to indicate that kcompactd will be able to do so, or
that it is beneficial from attempting to isolate memory.
Use the pageblock skip hint to avoid rescanning pageblocks needlessly
until that information is reset.
Signed-off-by: David Rientjes <rientjes@google.com>
---
mm/compaction.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/compaction.c b/mm/compaction.c
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1927,9 +1927,8 @@ static void kcompactd_do_work(pg_data_t *pgdat)
.total_free_scanned = 0,
.classzone_idx = pgdat->kcompactd_classzone_idx,
.mode = MIGRATE_SYNC_LIGHT,
- .ignore_skip_hint = true,
+ .ignore_skip_hint = false,
.gfp_mask = GFP_KERNEL,
-
};
trace_mm_compaction_kcompactd_wake(pgdat->node_id, cc.order,
cc.classzone_idx);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-08-15 23:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 23:39 David Rientjes [this message]
2017-08-15 23:39 ` [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks David Rientjes
2017-08-18 8:49 ` Michal Hocko
2017-08-21 0:36 ` [patch -mm] mm, compaction: persistently skip hugetlbfs pageblocks fix David Rientjes
2017-08-21 6:37 ` Michal Hocko
2017-08-23 8:41 ` [patch 2/2] mm, compaction: persistently skip hugetlbfs pageblocks Vlastimil Babka
2017-09-01 12:32 ` Vlastimil Babka
2017-09-11 1:13 ` David Rientjes
2017-09-11 1:12 ` David Rientjes
2017-09-11 6:50 ` Vlastimil Babka
2017-09-11 21:11 ` David Rientjes
2017-08-23 8:23 ` [patch 1/2] mm, compaction: kcompactd should not ignore pageblock skip Vlastimil Babka
2017-09-11 1:07 ` David Rientjes
2017-09-11 6:34 ` Vlastimil Babka
2017-09-11 21:13 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1708151638550.106658@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox