From: David Rientjes <rientjes@google.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>,
Larry Finger <Larry.Finger@lwfinger.net>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: Sleeping BUG in khugepaged for i586
Date: Wed, 14 Jun 2017 18:12:06 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1706141809390.124136@chino.kir.corp.google.com> (raw)
In-Reply-To: <20170608144831.GA19903@dhcp22.suse.cz>
On Thu, 8 Jun 2017, Michal Hocko wrote:
> collapse_huge_page
> pte_offset_map
> kmap_atomic
> kmap_atomic_prot
> preempt_disable
> __collapse_huge_page_copy
> pte_unmap
> kunmap_atomic
> __kunmap_atomic
> preempt_enable
>
> I suspect, so cond_resched seems indeed inappropriate on 32b systems.
>
Seems to be an issue for i386 and arm with ARM_LPAE. I'm slightly
surprised we can get away with __collapse_huge_page_swapin() for
VM_FAULT_RETRY, unless that hasn't been encountered yet. I think the
cond_resched() in __collapse_huge_page_copy() could be done only for
!in_atomic() if we choose.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-15 1:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-03 19:24 Larry Finger
2017-06-05 21:44 ` Andrew Morton
2017-06-06 14:02 ` Vlastimil Babka
2017-06-06 15:01 ` Larry Finger
2017-06-07 7:19 ` Vlastimil Babka
2017-06-07 20:56 ` David Rientjes
2017-06-08 14:48 ` Michal Hocko
2017-06-08 17:05 ` Matthew Wilcox
2017-06-08 20:18 ` Michal Hocko
2017-06-08 20:30 ` Michal Hocko
2017-06-09 6:48 ` Vlastimil Babka
2017-06-09 7:43 ` Michal Hocko
2017-06-09 14:28 ` Larry Finger
2017-06-09 22:38 ` David Rientjes
2017-06-10 8:09 ` Michal Hocko
2017-06-11 23:28 ` David Rientjes
2017-06-12 6:29 ` Michal Hocko
2017-06-15 0:28 ` David Rientjes
2017-06-15 1:12 ` David Rientjes [this message]
2017-06-15 8:32 ` Michal Hocko
2017-06-23 12:08 ` Michal Hocko
2017-06-23 13:13 ` Vlastimil Babka
2017-06-23 13:25 ` Michal Hocko
2017-06-23 15:28 ` Larry Finger
2017-06-08 15:29 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1706141809390.124136@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=Larry.Finger@lwfinger.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox