From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>
Subject: [patch] compiler, clang: suppress warning for unused static inline functions
Date: Wed, 24 May 2017 14:01:15 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1705241400510.49680@chino.kir.corp.google.com> (raw)
GCC explicitly does not warn for unused static inline functions for
-Wunused-function. The manual states:
Warn whenever a static function is declared but not defined or
a non-inline static function is unused.
Clang does warn for static inline functions that are unused.
It turns out that suppressing the warnings avoids potentially complex
#ifdef directives, which also reduces LOC.
Supress the warning for clang.
Signed-off-by: David Rientjes <rientjes@google.com>
---
include/linux/compiler-clang.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h
--- a/include/linux/compiler-clang.h
+++ b/include/linux/compiler-clang.h
@@ -15,3 +15,10 @@
* with any version that can compile the kernel
*/
#define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
+
+/*
+ * GCC does not warn about unused static inline functions for
+ * -Wunused-function. This turns out to avoid the need for complex #ifdef
+ * directives. Suppress the warning in clang as well.
+ */
+#define inline inline __attribute__((unused))
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-05-24 21:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 21:01 David Rientjes [this message]
2017-05-24 21:22 ` Matthias Kaehlcke
2017-05-24 21:32 ` Andrew Morton
2017-05-24 23:28 ` Doug Anderson
2017-05-31 0:10 ` David Rientjes
2017-05-31 1:53 ` Matthias Kaehlcke
2017-05-31 15:53 ` Doug Anderson
2017-05-31 18:26 ` Mark Brown
2017-05-31 21:45 ` David Rientjes
2017-05-31 22:31 ` Doug Anderson
2017-06-01 0:01 ` Matthias Kaehlcke
2017-05-25 5:52 ` Ingo Molnar
2017-05-25 16:14 ` Matthias Kaehlcke
2017-05-25 16:48 ` Joe Perches
2017-05-25 17:49 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1705241400510.49680@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=dianders@chromium.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mka@chromium.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox