From: David Rientjes <rientjes@google.com>
To: Grygorii Maistrenko <grygoriimkd@gmail.com>
Cc: Christoph Lameter <cl@linux.com>,
linux-mm@kvack.org, Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] slub: do not merge cache if slub_debug contains a never-merge flag
Date: Tue, 27 Dec 2016 16:17:55 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.10.1612271617450.57140@chino.kir.corp.google.com> (raw)
In-Reply-To: <20161226190855.GB2600@lp-laptop-d>
On Mon, 26 Dec 2016, Grygorii Maistrenko wrote:
> In case CONFIG_SLUB_DEBUG_ON=n, find_mergeable() gets debug features
> from commandline but never checks if there are features from the
> SLAB_NEVER_MERGE set.
> As a result selected by slub_debug caches are always mergeable if they
> have been created without a custom constructor set or without one of the
> SLAB_* debug features on.
>
> This moves the SLAB_NEVER_MERGE check below the flags update from
> commandline to make sure it won't merge the slab cache if one of the
> debug features is on.
>
> Signed-off-by: Grygorii Maistrenko <grygoriimkd@gmail.com>
Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-12-28 0:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 23:59 [PATCH] " Grygorii Maistrenko
2016-12-23 18:30 ` Christoph Lameter
2016-12-23 19:00 ` Grygorii Maistrenko
2016-12-24 23:09 ` Christoph Lameter
2016-12-26 19:08 ` [PATCH v2] " Grygorii Maistrenko
2016-12-27 9:50 ` Pekka Enberg
2016-12-28 0:17 ` David Rientjes [this message]
2017-01-01 12:44 ` Grygorii Maistrenko
2017-01-04 15:55 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1612271617450.57140@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=grygoriimkd@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox