From: David Rientjes <rientjes@google.com>
To: zijun_hu <zijun_hu@zoho.com>
Cc: zijun_hu@htc.com, Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org, tj@kernel.org,
mingo@kernel.org, iamjoonsoo.kim@lge.com,
mgorman@techsingularity.net
Subject: Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()
Date: Wed, 21 Sep 2016 16:15:42 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1609211612280.42217@chino.kir.corp.google.com> (raw)
In-Reply-To: <c5435f6f-d945-fae1-c17e-04530be08421@zoho.com>
On Thu, 22 Sep 2016, zijun_hu wrote:
> > We don't support inserting when va->va_start == tmp_va->va_end, plain and
> > simple. There's no reason to do so. NACK to the patch.
> >
> i am sorry i disagree with you because
> 1) in almost all context of vmalloc, original logic treat the special case as normal
> for example, __find_vmap_area() or alloc_vmap_area()
The ranges are [start, end) like everywhere else. __find_vmap_area() is
implemented as such for the passed address. The address is aligned in
alloc_vmap_area(), there's no surprise here. The logic is correct in
__insert_vmap_area().
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-09-21 23:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 4:23 zijun_hu
2016-09-21 21:10 ` David Rientjes
2016-09-21 22:35 ` zijun_hu
2016-09-21 22:45 ` David Rientjes
2016-09-21 23:10 ` zijun_hu
2016-09-21 23:15 ` David Rientjes [this message]
2016-09-21 23:55 ` zijun_hu
2016-09-27 6:07 ` zijun_hu
2016-09-22 1:36 ` [RFC PATCH " zijun_hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1609211612280.42217@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=tj@kernel.org \
--cc=zijun_hu@htc.com \
--cc=zijun_hu@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox