From: David Rientjes <rientjes@google.com>
To: zijun_hu <zijun_hu@zoho.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
zijun_hu@htc.com, tj@kernel.org, mingo@kernel.org,
iamjoonsoo.kim@lge.com, mgorman@techsingularity.net
Subject: Re: [PATCH 1/5] mm/vmalloc.c: correct a few logic error for __insert_vmap_area()
Date: Wed, 21 Sep 2016 14:10:49 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1609211408140.20971@chino.kir.corp.google.com> (raw)
In-Reply-To: <57E20B54.5020408@zoho.com>
On Wed, 21 Sep 2016, zijun_hu wrote:
> From: zijun_hu <zijun_hu@htc.com>
>
> correct a few logic error for __insert_vmap_area() since the else
> if condition is always true and meaningless
>
> in order to fix this issue, if vmap_area inserted is lower than one
> on rbtree then walk around left branch; if higher then right branch
> otherwise intersects with the other then BUG_ON() is triggered
>
Under normal operation, you're right that the "else if" conditional should
always succeed: we don't want to BUG() unless there's a bug. The original
code can catch instances when va->va_start == tmp_va->va_end where we
should BUG(). Your code silently ignores it.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-09-21 21:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 4:23 zijun_hu
2016-09-21 21:10 ` David Rientjes [this message]
2016-09-21 22:35 ` zijun_hu
2016-09-21 22:45 ` David Rientjes
2016-09-21 23:10 ` zijun_hu
2016-09-21 23:15 ` David Rientjes
2016-09-21 23:55 ` zijun_hu
2016-09-27 6:07 ` zijun_hu
2016-09-22 1:36 ` [RFC PATCH " zijun_hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1609211408140.20971@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=tj@kernel.org \
--cc=zijun_hu@htc.com \
--cc=zijun_hu@zoho.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox