From: David Rientjes <rientjes@google.com>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Dave Hansen <dave.hansen@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH V4] mm: Add sysfs interface to dump each node's zonelist information
Date: Mon, 12 Sep 2016 11:13:43 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1609121106500.39030@chino.kir.corp.google.com> (raw)
In-Reply-To: <57D63CB2.8070003@linux.vnet.ibm.com>
On Mon, 12 Sep 2016, Anshuman Khandual wrote:
> >> > after memory or node hot[un]plug is desirable. This change adds one
> >> > new sysfs interface (/sys/devices/system/memory/system_zone_details)
> >> > which will fetch and dump this information.
> > Doesn't this violate the "one value per file" sysfs rule? Does it
> > belong in debugfs instead?
>
> Yeah sure. Will make it a debugfs interface.
>
So the intended reader of this file is running as root?
> > I also really question the need to dump kernel addresses out, filtered
> > or not. What's the point?
>
> Hmm, thought it to be an additional information. But yes its additional
> and can be dropped.
>
I'm questioning if this information can be inferred from information
already in /proc/zoneinfo and sysfs. We know the no-fallback zonelist is
going to include the local node, and we know the other zonelists are
either node ordered or zone ordered (or do we need to extend
vm.numa_zonelist_order for default?). I may have missed what new
knowledge this interface is imparting on us.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-09-12 18:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 5:34 [PATCH V2 1/2] mm: Export definition of 'zone_names' array through mmzone.h Anshuman Khandual
2016-09-06 5:34 ` [PATCH V2 2/2] mm: Add sysfs interface to dump each node's zonelist information Anshuman Khandual
2016-09-06 6:11 ` kbuild test robot
2016-09-06 6:49 ` Anshuman Khandual
2016-09-06 8:31 ` [PATCH V3] " Anshuman Khandual
2016-09-06 9:05 ` kbuild test robot
2016-09-07 12:32 ` Anshuman Khandual
2016-09-06 20:36 ` Dave Hansen
2016-09-07 3:08 ` Kees Cook
2016-09-07 4:00 ` Anshuman Khandual
2016-09-08 2:46 ` [PATCH V4] " Anshuman Khandual
2016-09-08 7:44 ` kbuild test robot
2016-09-08 20:24 ` Dave Hansen
2016-09-12 5:27 ` Anshuman Khandual
2016-09-12 18:13 ` David Rientjes [this message]
2016-09-17 4:26 ` Anshuman Khandual
2016-09-20 0:54 ` David Rientjes
2016-10-13 14:38 ` Anshuman Khandual
2016-09-09 13:36 ` Michal Hocko
2016-09-12 5:24 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1609121106500.39030@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox