linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: "Chenjie (K)" <chenjie6@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	David.Woodhouse@intel.com, zhihui.gao@huawei.com,
	lizefan@huawei.com, stable@vger.kernel.org
Subject: Re: [PATCH] bugfix oom kill init lead panic
Date: Mon, 30 Nov 2015 14:08:23 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1511301407080.10460@chino.kir.corp.google.com> (raw)
In-Reply-To: <565BC23F.6070302@huawei.com>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 965 bytes --]

On Mon, 30 Nov 2015, Chenjie (K) wrote:

> My kernel version is 3.10 ,but the 4.3 is the same
> and the newest code is
> 
> 	for_each_process(p) {
> 		if (!process_shares_mm(p, mm))
> 			continue;
> 		if (same_thread_group(p, victim))
> 			continue;
> 		if (unlikely(p->flags & PF_KTHREAD))
> 			continue;
> 		if (p->signal->oom_score_adj == OOM_SCORE_ADJ_MIN)
> 			continue;
> 
> so this not add the i 1/4 ?is_global_init also.
> 
> when we vfork (CLONE_VM) a process,the copy_mm
> 	if (clone_flags & CLONE_VM) {
> 		atomic_inc(&oldmm->mm_users);
> 		mm = oldmm;
> 		goto good_mm;
> 	}
> use the parent mm.
> 

I think it might be a legitimate fix, but if the oom killer is killing pid 
9134 in your log then I assume the next call to the oom killer will panic 
the system anyway unless there is actually a process using less memory 
that can be killed.  Would you mind enabling vm.oom_dump_tasks (it should 
default to enabled) and post the entire oom killer log?

  reply	other threads:[~2015-11-30 22:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 10:54 chenjie6
2015-11-30  3:08 ` Andrew Morton
2015-11-30  3:27   ` Chenjie (K)
2015-11-30 22:08     ` David Rientjes [this message]
2015-12-01  4:15       ` Chenjie (K)
2015-12-01  6:09         ` Chenjie (K)
2015-12-01 23:41 ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1511301407080.10460@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=David.Woodhouse@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=chenjie6@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan@huawei.com \
    --cc=stable@vger.kernel.org \
    --cc=zhihui.gao@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox