From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by kanga.kvack.org (Postfix) with ESMTP id 347B66B0254 for ; Mon, 16 Nov 2015 05:10:13 -0500 (EST) Received: by pabfh17 with SMTP id fh17so173306003pab.0 for ; Mon, 16 Nov 2015 02:10:13 -0800 (PST) Received: from mail-pa0-x234.google.com (mail-pa0-x234.google.com. [2607:f8b0:400e:c03::234]) by mx.google.com with ESMTPS id rw4si49323043pab.147.2015.11.16.02.10.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Nov 2015 02:10:12 -0800 (PST) Received: by pabfh17 with SMTP id fh17so173305786pab.0 for ; Mon, 16 Nov 2015 02:10:12 -0800 (PST) Date: Mon, 16 Nov 2015 02:10:10 -0800 (PST) From: David Rientjes Subject: Re: [PATCH 4/7] mm/vmscan: page_is_file_cache can be boolean In-Reply-To: <1447656686-4851-5-git-send-email-baiyaowei@cmss.chinamobile.com> Message-ID: References: <1447656686-4851-1-git-send-email-baiyaowei@cmss.chinamobile.com> <1447656686-4851-5-git-send-email-baiyaowei@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Yaowei Bai Cc: akpm@linux-foundation.org, bhe@redhat.com, dan.j.williams@intel.com, dave.hansen@linux.intel.com, dave@stgolabs.net, dhowells@redhat.com, dingel@linux.vnet.ibm.com, hannes@cmpxchg.org, hillf.zj@alibaba-inc.com, holt@sgi.com, iamjoonsoo.kim@lge.com, joe@perches.com, kuleshovmail@gmail.com, mgorman@suse.de, mhocko@suse.cz, mike.kravetz@oracle.com, n-horiguchi@ah.jp.nec.com, penberg@kernel.org, sasha.levin@oracle.com, tj@kernel.org, tony.luck@intel.com, vbabka@suse.cz, vdavydov@parallels.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon, 16 Nov 2015, Yaowei Bai wrote: > diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h > index cf55945..af73135 100644 > --- a/include/linux/mm_inline.h > +++ b/include/linux/mm_inline.h > @@ -8,8 +8,8 @@ > * page_is_file_cache - should the page be on a file LRU or anon LRU? > * @page: the page to test > * > - * Returns 1 if @page is page cache page backed by a regular filesystem, > - * or 0 if @page is anonymous, tmpfs or otherwise ram or swap backed. > + * Returns true if @page is page cache page backed by a regular filesystem, > + * or false if @page is anonymous, tmpfs or otherwise ram or swap backed. > * Used by functions that manipulate the LRU lists, to sort a page > * onto the right LRU list. > * > @@ -17,7 +17,7 @@ > * needs to survive until the page is last deleted from the LRU, which > * could be as far down as __page_cache_release. > */ > -static inline int page_is_file_cache(struct page *page) > +static inline bool page_is_file_cache(struct page *page) > { > return !PageSwapBacked(page); > } Since page_is_file_cache() is often used to determine which zlc to increment or decrement (usage such as NR_ISOLATED_ANON + page_is_file_cache(page)), I don't think this style is helpful. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org