From: David Rientjes <rientjes@google.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] tools/vm/page-types: suppress gcc warnings
Date: Wed, 11 Nov 2015 21:46:23 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.10.1511112120020.9296@chino.kir.corp.google.com> (raw)
In-Reply-To: <20151112005455.GA1651@swordfish>
On Thu, 12 Nov 2015, Sergey Senozhatsky wrote:
> > This can't possibly be correct, the warnings are legitimate and the result
> > of the sigsetjmp() in the function. You may be interested in
> > returns_twice rather than marking random automatic variables as volatile.
>
> Hm, ok. I saw no probs with `int first' and `end' being volatile
>
This will only happen with the undocumented change in your first patch
which adds -O2.
I don't know what version of gcc you're using, but only "first" and "end"
being marked volatile isn't sufficient since mere code inspection would
show that "off" will also be clobbered -- it's part of the loop.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-11-12 5:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 13:32 [PATCH 0/3] tools/vm: trivial fixes Sergey Senozhatsky
2015-11-10 13:32 ` [PATCH 1/3] tools/vm: fix Makefile multi-targets Sergey Senozhatsky
2015-11-10 15:29 ` Christoph Lameter
2015-11-11 12:28 ` Sergey Senozhatsky
2015-11-11 20:34 ` David Rientjes
2015-11-12 0:58 ` Sergey Senozhatsky
2015-11-10 13:32 ` [PATCH 2/3] tools/vm/page-types: suppress gcc warnings Sergey Senozhatsky
2015-11-11 20:44 ` David Rientjes
2015-11-12 0:54 ` Sergey Senozhatsky
2015-11-12 5:46 ` David Rientjes [this message]
2015-11-10 13:32 ` [PATCH 3/3] tools/vm/slabinfo: update struct slabinfo members' types Sergey Senozhatsky
2015-11-10 15:28 ` Christoph Lameter
2015-11-11 20:55 ` David Rientjes
2015-11-12 1:13 ` Sergey Senozhatsky
2015-11-12 5:07 ` David Rientjes
2015-11-12 6:17 ` Sergey Senozhatsky
2015-11-12 9:59 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1511112120020.9296@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox