From: David Rientjes <rientjes@google.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: gregkh@linuxfoundation.org, mhocko@kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] android, lmk: Send SIGKILL before setting TIF_MEMDIE.
Date: Wed, 9 Sep 2015 14:55:59 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1509091454020.20924@chino.kir.corp.google.com> (raw)
In-Reply-To: <1441517135-4980-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
On Sun, 6 Sep 2015, Tetsuo Handa wrote:
> It was observed that setting TIF_MEMDIE before sending SIGKILL at
> oom_kill_process() allows memory reserves to be depleted by allocations
> which are not needed for terminating the OOM victim.
>
I don't understand what you are trying to fix. Sending a SIGKILL first
does not guarantee that it is handling that signal before accessing memory
reserves. I have no objection to the patch, but I don't think it actually
matters either way and is relatively pointless.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-09-09 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-06 5:25 Tetsuo Handa
2015-09-09 21:55 ` David Rientjes [this message]
2015-09-11 13:51 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1509091454020.20924@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox