From: David Rientjes <rientjes@google.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: gregkh@linuxfoundation.org, arve@android.com,
riandrews@android.com, devel@driverdev.osuosl.org,
linux-mm@kvack.org, mhocko@kernel.org, hannes@cmpxchg.org
Subject: Re: [PATCH 1/2] android, lmk: Protect task->comm with task_lock.
Date: Tue, 1 Sep 2015 15:28:41 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1509011527500.11913@chino.kir.corp.google.com> (raw)
In-Reply-To: <201508262117.FAH43726.tOFMVJSLQOFHFO@I-love.SAKURA.ne.jp>
On Wed, 26 Aug 2015, Tetsuo Handa wrote:
> Hello.
>
> Next patch is mm-related but this patch is not.
> Via which tree should these patches go?
> ----------------------------------------
> >From 48c1b457eb32d7a029e9a078ee0a67974ada9261 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Wed, 26 Aug 2015 20:49:17 +0900
> Subject: [PATCH 1/2] android, lmk: Protect task->comm with task_lock.
>
> Passing task->comm to printk() wants task_lock() protection in order
> to avoid potentially emitting garbage bytes.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
We've gone through these types of patches before and Andrew has said that
we aren't necessarily concerned with protecting task->comm here since the
worst-case scenario is that it becomes truncated.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-09-01 22:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 12:17 Tetsuo Handa
2015-08-26 12:19 ` [PATCH 2/2] android, lmk: Reverse the order of setting TIF_MEMDIE and sending SIGKILL Tetsuo Handa
2015-08-26 15:34 ` Tetsuo Handa
2015-08-27 8:44 ` Michal Hocko
2015-09-03 1:06 ` Greg KH
2015-09-04 14:05 ` Michal Hocko
2015-09-04 17:15 ` Greg KH
2015-09-04 18:06 ` Tetsuo Handa
2015-09-04 20:29 ` Greg KH
2015-09-01 22:28 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1509011527500.11913@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=riandrews@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox