From: David Rientjes <rientjes@google.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
kbuild test robot <fengguang.wu@intel.com>,
Oleg Nesterov <oleg@redhat.com>,
kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: vm_flags, vm_flags_t and __nocast
Date: Fri, 24 Jul 2015 13:15:28 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1507241314300.5215@chino.kir.corp.google.com> (raw)
In-Reply-To: <20150724100940.GB22732@node.dhcp.inet.fi>
On Fri, 24 Jul 2015, Kirill A. Shutemov wrote:
> sparse complains on each and every vm_flags_t initialization, even with
> proper VM_* constants.
>
> Do we really want to fix that?
>
> To me it's too much pain and no gain. __nocast is not beneficial here.
>
> And I'm not sure that vm_flags_t typedef was a good idea after all.
> Originally, it was intended to become 64-bit one day, but four years later
> it's still unsigned long. Plain unsigned long works fine for other bit
> field.
>
> What is special about vm_flags?
>
Maybe remove the __nocast until it's a different type? Seems like all
these sites would have to be audited when that happens anyway.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-24 20:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 8:18 [mmotm:master 371/385] arch/x86/mm/mpx.c:71:54: sparse: implicit cast to nocast type kbuild test robot
2015-07-24 10:09 ` vm_flags, vm_flags_t and __nocast Kirill A. Shutemov
2015-07-24 20:15 ` David Rientjes [this message]
2015-08-03 15:51 ` Kirill A. Shutemov
2015-08-03 17:33 ` Oleg Nesterov
2015-08-06 2:07 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1507241314300.5215@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox