From: David Rientjes <rientjes@google.com>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: linux-mm@kvack.org, Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/slub: fix slab double-free in case of duplicate sysfs filename
Date: Wed, 15 Jul 2015 17:27:43 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1507151727320.9230@chino.kir.corp.google.com> (raw)
In-Reply-To: <20150714131704.21442.17939.stgit@buzz>
On Tue, 14 Jul 2015, Konstantin Khlebnikov wrote:
> sysfs_slab_add() shouldn't call kobject_put at error path: this puts
> last reference of kmem-cache kobject and frees it. Kmem cache will be
> freed second time at error path in kmem_cache_create().
>
> For example this happens when slub debug was enabled in runtime and
> somebody creates new kmem cache:
>
> # echo 1 | tee /sys/kernel/slab/*/sanity_checks
> # modprobe configfs
>
> "configfs_dir_cache" cannot be merged because existing slab have debug and
> cannot create new slab because unique name ":t-0000096" already taken.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-07-16 0:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 13:17 Konstantin Khlebnikov
2015-07-14 13:17 ` [PATCH 2/2] mm/slub: disable merging after enabling debug in runtime Konstantin Khlebnikov
2015-07-14 18:11 ` Christoph Lameter
2015-07-14 20:21 ` Konstantin Khlebnikov
2015-07-14 21:18 ` Christoph Lameter
2015-07-17 9:37 ` Konstantin Khlebnikov
2015-07-17 15:09 ` Christoph Lameter
2015-07-17 15:25 ` Konstantin Khlebnikov
2015-07-14 18:11 ` [PATCH 1/2] mm/slub: fix slab double-free in case of duplicate sysfs filename Christoph Lameter
2015-07-16 0:27 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1507151727320.9230@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox