From: David Rientjes <rientjes@google.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andrey Ryabinin <a.ryabinin@samsung.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mempool: add missing include
Date: Thu, 9 Apr 2015 12:31:05 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1504091230400.11370@chino.kir.corp.google.com> (raw)
In-Reply-To: <3302342.cNyRUGN06P@wuerfel>
On Thu, 9 Apr 2015, Arnd Bergmann wrote:
> This is a fix^3 for the mempool poisoning patch, which introduces
> a compile-time error on some ARM randconfig builds:
>
> mm/mempool.c: In function 'check_element':
> mm/mempool.c:65:16: error: implicit declaration of function 'kmap_atomic' [-Werror=implicit-function-declaration]
> void *addr = kmap_atomic((struct page *)element);
>
> The problem is clearly the missing declaration, and including
> linux/highmem.h fixes it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: a3db5a8463b0db ("mm, mempool: poison elements backed by page allocator fix fix")
Acked-by: David Rientjes <rientjes@google.com>
Thanks! Can you confirm that this is because CONFIG_BLOCK is disabled and
not something else?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-04-09 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 9:46 Arnd Bergmann
2015-04-09 19:31 ` David Rientjes [this message]
2015-04-09 21:14 ` Arnd Bergmann
2015-04-09 23:12 ` David Rientjes
2015-04-09 23:22 ` Jim Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1504091230400.11370@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=a.ryabinin@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox