Re: [PATCH 2/2] clean up to just return ERR_PTR

[David Rientjes <rientjes@google.com>]

On Tue, 17 Mar 2015, denc716@gmail.com wrote:

> Signed-off-by: Derek Che <crquan@ymail.com>
> Acked-by: "Kirill A. Shutemov" <kirill@shutemov.name>
> Acked-by: David Rientjes <rientjes@google.com>

I don't believe Kirill ever acked this patch, you need to wait for the 
person to respond to your email with the line themself before you can add 
it to your commit message.  Please see Documentation/SubmittingPatches.

He also suggested that this patch be done, so you need to add

Suggested-by: Kirill A. Shutemov <kirill@shutemov.name>

You need a proper subject line for the patch, in this case it would be 
something like "mm, mremap: avoid unnecessary gotos in vma_to_resize()" 
and you also need a proper commit message such as:

	The "goto"s in vma_to_resize() aren't necessary since they just
	return a specific value.  Switch these statements to explicit
	return statements.

My acked-by was never given before this, but it can be added because it 
looks good:

Acked-by: David Rientjes <rientjes@google.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>