From: David Rientjes <rientjes@google.com>
To: Michal Hocko <mhocko@suse.cz>
Cc: Leon Yu <chianglungyu@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Rik van Riel <riel@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] mm: fix anon_vma->degree underflow in anon_vma endless growing prevention
Date: Tue, 3 Mar 2015 21:54:38 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.10.1503032153510.12253@chino.kir.corp.google.com> (raw)
In-Reply-To: <20150303133642.GC2409@dhcp22.suse.cz>
On Tue, 3 Mar 2015, Michal Hocko wrote:
> I think we can safely remove the following code as well, because it is
> anon_vma_clone which is responsible to do all the cleanups.
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 943c6ad18b1d..06a6076c92e5 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -774,10 +774,8 @@ again: remove_next = 1 + (end > next->vm_end);
>
> importer->anon_vma = exporter->anon_vma;
> error = anon_vma_clone(importer, exporter);
> - if (error) {
> - importer->anon_vma = NULL;
> + if (error)
> return error;
> - }
> }
> }
>
When Michal proposes this on top of -mm, feel free to add my
Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-03-04 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 12:02 Leon Yu
2015-03-03 12:36 ` Konstantin Khlebnikov
2015-03-03 13:36 ` Michal Hocko
2015-03-03 14:05 ` Leon Yu
2015-03-04 5:54 ` David Rientjes [this message]
2015-03-03 22:00 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1503032153510.12253@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=chianglungyu@gmail.com \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=riel@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox