From: David Rientjes <rientjes@google.com>
To: Andrey Skvortsov <andrej.skvortzov@gmail.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Jesper Dangaard Brouer <brouer@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/slub: suppress BUG messages for kmem_cache_alloc/kmem_cache_free
Date: Thu, 22 Jan 2015 15:19:18 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.10.1501221518020.27807@chino.kir.corp.google.com> (raw)
In-Reply-To: <1421932519-21036-1-git-send-email-Andrej.Skvortzov@gmail.com>
On Thu, 22 Jan 2015, Andrey Skvortsov wrote:
> diff --git a/mm/slub.c b/mm/slub.c
> index ceee1d7..6bcd031 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2404,7 +2404,7 @@ redo:
> */
> do {
> tid = this_cpu_read(s->cpu_slab->tid);
> - c = this_cpu_ptr(s->cpu_slab);
> + c = raw_cpu_ptr(s->cpu_slab);
> } while (IS_ENABLED(CONFIG_PREEMPT) && unlikely(tid != c->tid));
>
> /*
> @@ -2670,7 +2670,7 @@ redo:
> */
> do {
> tid = this_cpu_read(s->cpu_slab->tid);
> - c = this_cpu_ptr(s->cpu_slab);
> + c = raw_cpu_ptr(s->cpu_slab);
> } while (IS_ENABLED(CONFIG_PREEMPT) && unlikely(tid != c->tid));
>
> /* Same with comment on barrier() in slab_alloc_node() */
This should already be fixed with
http://ozlabs.org/~akpm/mmotm/broken-out/mm-slub-optimize-alloc-free-fastpath-by-removing-preemption-on-off-v3.patch
You can find the latest mmotm, which was just released, at
http://ozlabs.org/~akpm/mmotm and it should be in linux-next tomorrow.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-22 23:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 13:15 Andrey Skvortsov
2015-01-22 23:19 ` David Rientjes [this message]
2015-01-23 6:58 ` Andrey Skvortsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1501221518020.27807@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=andrej.skvortzov@gmail.com \
--cc=brouer@redhat.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox