From: David Rientjes <rientjes@google.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Petr Cermak <petrcermak@chromium.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Andrew Morton <akpm@linux-foundation.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Primiano Tucci <primiano@chromium.org>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH v2 2/2] task_mmu: Add user-space support for resetting mm->hiwater_rss (peak RSS)
Date: Wed, 21 Jan 2015 14:58:48 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.10.1501211452580.2716@chino.kir.corp.google.com> (raw)
In-Reply-To: <20150114233630.GA14615@node.dhcp.inet.fi>
On Thu, 15 Jan 2015, Kirill A. Shutemov wrote:
> I'm not sure if it should be considered ABI break or not. Just asking.
>
> I would like to hear opinion from other people.
>
I think the bigger concern would be that this, and any new line such as
resettable_hiwater_rss, invalidates itself entirely. Any process that
checks the hwm will not know of other processes that reset it, so the
value itself has no significance anymore. It would just be the mark since
the last clear at an unknown time. Userspace can monitor the rss of a
process by reading /proc/pid/stat, there's no need for the kernel to do
something that userspace can do.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-01-21 22:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 17:06 [PATCH v2 0/2] " Petr Cermak
2015-01-07 17:06 ` [PATCH v2 1/2] task_mmu: Reduce excessive indentation in clear_refs_write Petr Cermak
2015-01-07 17:06 ` [PATCH v2 2/2] task_mmu: Add user-space support for resetting mm->hiwater_rss (peak RSS) Petr Cermak
2015-01-07 17:24 ` Kirill A. Shutemov
2015-01-14 15:22 ` Petr Cermak
2015-01-14 23:36 ` Kirill A. Shutemov
2015-01-21 22:58 ` David Rientjes [this message]
2015-01-22 0:22 ` Primiano Tucci
2015-01-22 23:27 ` David Rientjes
2015-01-23 0:28 ` Primiano Tucci
2015-01-27 0:00 ` David Rientjes
2015-02-03 3:26 ` Petr Cermak
2015-02-03 15:51 ` Minchan Kim
2015-02-03 20:16 ` David Rientjes
2015-01-14 23:39 ` Kirill A. Shutemov
2015-01-15 16:46 ` Petr Cermak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1501211452580.2716@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=hughd@google.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=petrcermak@chromium.org \
--cc=primiano@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox