From: David Rientjes <rientjes@google.com>
To: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Rafael Aquini <aquini@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
oleg@redhat.com, linux-mm@kvack.org, Mel Gorman <mel@csn.ul.ie>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH] proc: task_mmu: show page size in /proc/<pid>/numa_maps
Date: Mon, 22 Dec 2014 14:21:35 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.10.1412221420170.11431@chino.kir.corp.google.com> (raw)
In-Reply-To: <54985C08.8080608@linux.intel.com>
On Mon, 22 Dec 2014, Dave Hansen wrote:
> > Remaining question here is: should we print out 'pagesize' deliberately
> > or conditionally, only to disambiguate cases where page_size != PAGE_SIZE?
>
> I say print it unconditionally. Not to completely overdesign this, but
> I do think we should try to at least mirror the terminology that smaps uses:
>
> KernelPageSize: 4 kB
> MMUPageSize: 4 kB
>
> So definitely call this kernelpagesize.
>
Feel free to add my acked-by if this patch prints it unconditionally and
renames this to kernelpagesize per Dave. I agree we need to leave "huge"
for existing dependencies even though we have multiple possible hugepage
sizes.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-12-22 22:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-20 13:54 Rafael Aquini
2014-12-20 16:40 ` Dave Hansen
2014-12-22 22:27 ` David Rientjes
2014-12-20 18:36 ` Johannes Weiner
2014-12-20 19:44 ` Rafael Aquini
2014-12-21 18:02 ` Dave Hansen
2014-12-21 22:28 ` Rafael Aquini
2014-12-22 17:10 ` Dave Hansen
2014-12-22 17:25 ` Rafael Aquini
2014-12-22 17:59 ` Dave Hansen
2014-12-22 22:21 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1412221420170.11431@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=dave.hansen@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox