From: David Rientjes <rientjes@google.com>
To: Andrey Ryabinin <a.ryabinin@samsung.com>
Cc: akpm@linux-foundation.org, Dmitry Vyukov <dvyukov@google.com>,
Manfred Spraul <manfred@colorfullife.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"nadia.derbey@bull.net" <Nadia.Derbey@bull.net>,
aquini@redhat.com, Joe Perches <joe@perches.com>,
avagin@openvz.org, LKML <linux-kernel@vger.kernel.org>,
Kostya Serebryany <kcc@google.com>,
Dmitry Chernenkov <dmitryc@google.com>,
Andrey Konovalov <andreyknvl@google.com>,
Konstantin Khlebnikov <koct9i@gmail.com>,
kasan-dev <kasan-dev@googlegroups.com>,
Davidlohr Bueso <dave@stgolabs.net>,
linux-mm@kvack.org
Subject: Re: [PATCH 1/2] hugetlb, sysctl: pass '.extra1 = NULL' rather then '.extra1 = &zero'
Date: Wed, 17 Dec 2014 16:38:10 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.10.1412171636400.23841@chino.kir.corp.google.com> (raw)
In-Reply-To: <1418826650-10145-1-git-send-email-a.ryabinin@samsung.com>
On Wed, 17 Dec 2014, Andrey Ryabinin wrote:
> Commit ed4d4902ebdd ("mm, hugetlb: remove hugetlb_zero and hugetlb_infinity") replaced
> 'unsigned long hugetlb_zero' with 'int zero' leading to out-of-bounds access
> in proc_doulongvec_minmax().
> Use '.extra1 = NULL' instead of '.extra1 = &zero'. Passing NULL is equivalent to
> passing minimal value, which is 0 for unsigned types.
>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Suggested-by: Manfred Spraul <manfred@colorfullife.com>
> Fixes: ed4d4902ebdd ("mm, hugetlb: remove hugetlb_zero and hugetlb_infinity")
> Signed-off-by: Andrey Ryabinin <a.ryabinin@samsung.com>
Acked-by: David Rientjes <rientjes@google.com>
Patch title is a little awkward, though, maybe "mm, hugetlb: remove
unnecessary lower bound on sysctl handlers"?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-12-18 0:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <548CA6B6.3060901@colorfullife.com>
2014-12-17 14:30 ` Andrey Ryabinin
2014-12-17 14:30 ` [PATCH 2/2] mm: hugetlb: fix type of hugetlb_treat_as_movable variable Andrey Ryabinin
2014-12-18 0:39 ` David Rientjes
2014-12-18 0:38 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1412171636400.23841@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=Nadia.Derbey@bull.net \
--cc=a.ryabinin@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aquini@redhat.com \
--cc=avagin@openvz.org \
--cc=dave@stgolabs.net \
--cc=dmitryc@google.com \
--cc=dvyukov@google.com \
--cc=joe@perches.com \
--cc=kasan-dev@googlegroups.com \
--cc=kcc@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=koct9i@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=manfred@colorfullife.com \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox