From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by kanga.kvack.org (Postfix) with ESMTP id EF8BC6B0038 for ; Thu, 11 Sep 2014 19:37:22 -0400 (EDT) Received: by mail-wi0-f177.google.com with SMTP id em10so83167wid.16 for ; Thu, 11 Sep 2014 16:37:22 -0700 (PDT) Received: from Galois.linutronix.de (Galois.linutronix.de. [2001:470:1f0b:db:abcd:42:0:1]) by mx.google.com with ESMTPS id gr8si9044826wib.22.2014.09.11.16.37.21 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 11 Sep 2014 16:37:21 -0700 (PDT) Date: Fri, 12 Sep 2014 01:37:10 +0200 (CEST) From: Thomas Gleixner Subject: Re: [PATCH v8 07/10] x86, mpx: decode MPX instruction to get bound violation information In-Reply-To: <541223B1.5040705@zytor.com> Message-ID: References: <1410425210-24789-1-git-send-email-qiaowei.ren@intel.com> <1410425210-24789-8-git-send-email-qiaowei.ren@intel.com> <5412230A.6090805@intel.com> <541223B1.5040705@zytor.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: "H. Peter Anvin" Cc: Dave Hansen , Qiaowei Ren , Ingo Molnar , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Thu, 11 Sep 2014, H. Peter Anvin wrote: > On 09/11/2014 03:32 PM, Dave Hansen wrote: > > On 09/11/2014 03:18 PM, Thomas Gleixner wrote: > >> On Thu, 11 Sep 2014, Qiaowei Ren wrote: > >>> This patch sets bound violation fields of siginfo struct in #BR > >>> exception handler by decoding the user instruction and constructing > >>> the faulting pointer. > >>> > >>> This patch does't use the generic decoder, and implements a limited > >>> special-purpose decoder to decode MPX instructions, simply because the > >>> generic decoder is very heavyweight not just in terms of performance > >>> but in terms of interface -- because it has to. > >> > >> And why is that an argument to add another special purpose decoder? > > > > Peter asked for it to be done this way specifically: > > > > https://lkml.org/lkml/2014/6/19/411 > > > > Specifically because marshaling the data in and out of the generic > decoder was more complex than a special-purpose decoder. I did not look at that detail and I trust your judgement here, but that is in no way explained in the changelog. This whole patchset is a pain to review due to half baken changelogs and complete lack of a proper design description. Thanks, tglx -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org