From: Christoph Lameter <cl@linux.com>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: akpm@linux-foundation.org, riel@redhat.com, aarcange@redhat.com,
oleg@redhat.com, cldu@marvell.com, fabf@skynet.be,
sasha.levin@oracle.com, zhangyanfei@cn.fujitsu.com,
iamjoonsoo.kim@lge.com, n-horiguchi@ah.jp.nec.com,
kirill.shutemov@linux.intel.com, liwanp@linux.vnet.ibm.com,
gorcunov@gmail.com, minchan@kernel.org,
dave.hansen@linux.intel.com, toshi.kani@hp.com,
paul.gortmaker@windriver.com, srivatsa.bhat@linux.vnet.ibm.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH 1/3] mm: add comment for __mod_zone_page_stat
Date: Mon, 12 May 2014 11:57:15 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1405121155220.26638@gentwo.org> (raw)
In-Reply-To: <1399912423-25601-1-git-send-email-nasa4836@gmail.com>
On Tue, 13 May 2014, Jianyu Zhan wrote:
> diff --git a/mm/internal.h b/mm/internal.h
> index 07b6736..53d439e 100644
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -196,7 +196,12 @@ static inline int mlocked_vma_newpage(struct vm_area_struct *vma,
> return 0;
>
> if (!TestSetPageMlocked(page)) {
> - mod_zone_page_state(page_zone(page), NR_MLOCK,
> + /*
> + * We use the irq-unsafe __mod_zone_page_stat because
> + * this counter is not modified from interrupt context, and the
> + * pte lock is held(spinlock), which implies preemtion disabled.
Preemption is mis-spelled throughout.
Otherwise
Reviewed-by: Christoph Lameter <cl@linux.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-05-12 16:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 16:33 Jianyu Zhan
2014-05-12 16:57 ` Christoph Lameter [this message]
2014-05-14 3:59 ` Hugh Dickins
-- strict thread matches above, loose matches on Subject: below --
2014-05-12 17:36 Jianyu Zhan
2014-05-11 12:31 Jianyu Zhan
2014-05-12 14:01 ` Christoph Lameter
2014-05-12 15:19 ` Jianyu Zhan
2014-05-12 16:05 ` Christoph Lameter
2014-05-12 16:07 ` Christoph Lameter
2014-05-10 7:15 Jianyu Zhan
2014-05-10 19:51 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1405121155220.26638@gentwo.org \
--to=cl@linux.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cldu@marvell.com \
--cc=dave.hansen@linux.intel.com \
--cc=fabf@skynet.be \
--cc=gorcunov@gmail.com \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=minchan@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=nasa4836@gmail.com \
--cc=oleg@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=toshi.kani@hp.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox