From: Christoph Lameter <cl@linux.com>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>, Rik van Riel <riel@redhat.com>,
Mel Gorman <mgorman@suse.de>,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
Andrea Arcangeli <aarcange@redhat.com>,
fabf@skynet.be, sasha.levin@oracle.com, oleg@redhat.com,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
iamjoonsoo.kim@lge.com, kirill.shutemov@linux.intel.com,
Cyrill Gorcunov <gorcunov@gmail.com>,
dave.hansen@linux.intel.com, toshi.kani@hp.com,
paul.gortmaker@windriver.com, srivatsa.bhat@linux.vnet.ibm.com,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] mm: add comment for __mod_zone_page_stat
Date: Mon, 12 May 2014 11:05:24 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1405121102170.17673@gentwo.org> (raw)
In-Reply-To: <CAHz2CGUfLx7DNgdNoAL0G3a9Ht6yf3bhWaojjNx91aF7L-iDQw@mail.gmail.com>
On Mon, 12 May 2014, Jianyu Zhan wrote:
> This means they guarantee that even they are preemted the vm
> counter won't be modified incorrectly. Because the counter is page-related
> (e.g., a new anon page added), and they are exclusively hold the pte lock.
But there are multiple pte locks for numerous page. Another process could
modify the counter because the pte lock for a different page was
available which would cause counter corruption.
> So, as you concludes in the other mail that __modd_zone_page_stat
> couldn't be used.
> in mlocked_vma_newpage, then what qualifies other call sites for using
> it, in the same situation?
Preemption should be off in those functions because a spinlock is being
held.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-05-12 16:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 12:31 Jianyu Zhan
2014-05-12 14:01 ` Christoph Lameter
2014-05-12 15:19 ` Jianyu Zhan
2014-05-12 16:05 ` Christoph Lameter [this message]
2014-05-12 16:07 ` Christoph Lameter
-- strict thread matches above, loose matches on Subject: below --
2014-05-12 17:36 Jianyu Zhan
2014-05-12 16:33 Jianyu Zhan
2014-05-12 16:57 ` Christoph Lameter
2014-05-14 3:59 ` Hugh Dickins
2014-05-10 7:15 Jianyu Zhan
2014-05-10 19:51 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1405121102170.17673@gentwo.org \
--to=cl@linux.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=fabf@skynet.be \
--cc=gorcunov@gmail.com \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=nasa4836@gmail.com \
--cc=oleg@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=toshi.kani@hp.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox