From: Christoph Lameter <cl@linux.com>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: akpm@linux-foundation.org, mhocko@suse.cz, hannes@cmpxchg.org,
riel@redhat.com, minchan@kernel.org, zhangyanfei@cn.fujitsu.com,
hanpt@linux.vnet.ibm.com, sasha.levin@oracle.com,
oleg@redhat.com, fabf@skynet.be, mgorman@suse.de,
aarcange@redhat.com, cldu@marvell.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: use a irq-safe __mod_zone_page_state in mlocked_vma_newpage()
Date: Mon, 12 May 2014 08:57:20 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1405120855470.3090@gentwo.org> (raw)
In-Reply-To: <1399652208-18987-1-git-send-email-nasa4836@gmail.com>
On Sat, 10 May 2014, Jianyu Zhan wrote:
> mlocked_vma_newpage() is only called in fault path by
> page_add_new_anon_rmap(), which is called on a *new* page.
> And such page is initially only visible via the pagetables, and the
> pte is locked while calling page_add_new_anon_rmap(), so we need not
> use an irq-safe mod_zone_page_state() here, using a light-weight version
> __mod_zone_page_state() would be OK.
This has nothing to do with the safety of statistics operations that work
on different data structures. Which leads to the conclusion that
__mod_page_state cannot be used here.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-05-12 13:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 16:16 Jianyu Zhan
2014-05-09 16:34 ` Christoph Lameter
2014-05-09 19:54 ` Andrew Morton
2014-05-12 13:57 ` Christoph Lameter [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-05-09 15:17 Jianyu Zhan
2014-05-09 15:56 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1405120855470.3090@gentwo.org \
--to=cl@linux.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cldu@marvell.com \
--cc=fabf@skynet.be \
--cc=hannes@cmpxchg.org \
--cc=hanpt@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=minchan@kernel.org \
--cc=nasa4836@gmail.com \
--cc=oleg@redhat.com \
--cc=riel@redhat.com \
--cc=sasha.levin@oracle.com \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox