From: Christoph Lameter <cl@linux.com>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
akpm@linux-foundation.org, mhocko@suse.cz, glommer@gmail.com,
penberg@kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, devel@openvz.org
Subject: Re: [PATCH -mm 1/4] memcg, slab: do not schedule cache destruction when last page goes away
Date: Tue, 15 Apr 2014 14:32:17 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1404151431400.29234@gentwo.org> (raw)
In-Reply-To: <534D83AB.6040107@parallels.com>
On Tue, 15 Apr 2014, Vladimir Davydov wrote:
> > There is already logic in both slub and slab that does that on cache
> > close.
>
> Yeah, but here the question is when we should close caches left after memcg
> offline. Obviously we should do it after all objects of such a cache have
> gone, but when exactly? Do it immediately after the last kfree (have to count
> objects per cache then AFAIU) or may be check periodically (or on vmpressure)
> that the cache is empty by issuing kmem_cache_shrink and looking if
> memcg_params::nr_pages = 0?
Guess check once in a while if you have no other way to determine this. A
hook in kfree() would impact all users.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-04-15 19:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 15:02 [PATCH -mm 0/4] memcg-vs-slab cleanup Vladimir Davydov
2014-04-09 15:02 ` [PATCH -mm 1/4] memcg, slab: do not schedule cache destruction when last page goes away Vladimir Davydov
2014-04-15 2:16 ` Johannes Weiner
2014-04-15 6:24 ` Vladimir Davydov
2014-04-15 15:17 ` Christoph Lameter
2014-04-15 19:08 ` Vladimir Davydov
2014-04-15 19:32 ` Christoph Lameter [this message]
2014-04-09 15:02 ` [PATCH -mm 2/4] memcg, slab: merge memcg_{bind,release}_pages to memcg_{un}charge_slab Vladimir Davydov
2014-04-09 15:02 ` [PATCH -mm 3/4] memcg, slab: change memcg::slab_caches_mutex vs slab_mutex locking order Vladimir Davydov
2014-04-09 15:02 ` [PATCH -mm 4/4] memcg, slab: remove memcg_cache_params::destroy work Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1404151431400.29234@gentwo.org \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=devel@openvz.org \
--cc=glommer@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=penberg@kernel.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox