From: Christoph Lameter <cl@linux.com>
To: Joe Perches <joe@perches.com>
Cc: Mitchel Humpherys <mitchelh@codeaurora.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: convert some level-less printks to pr_*
Date: Thu, 3 Apr 2014 11:33:15 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1404031132310.21658@nuc> (raw)
In-Reply-To: <1396291441.21529.52.camel@joe-AO722>
On Mon, 31 Mar 2014, Joe Perches wrote:
> On Mon, 2014-03-31 at 13:35 -0500, Christoph Lameter wrote:
> > On Thu, 27 Mar 2014, Mitchel Humpherys wrote:
> >
> > > diff --git a/mm/slub.c b/mm/slub.c
> []
> > > @@ -9,6 +9,8 @@
> > > * (C) 2011 Linux Foundation, Christoph Lameter
> > > */
> > >
> > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> >
> > This is implicitly used by some macros? If so then please define this
> > elsewhere. I do not see any use in slub.c of this one.
>
> Hi Christoph
>
> All the pr_<level> macros use it.
>
> from include/linux/printk.h:
Ok then why do you add the definition to slub.c?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-04-03 16:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 17:54 [PATCH v2] Some printk cleanup in mm Mitchel Humpherys
2014-03-27 17:54 ` [PATCH v2] mm: convert some level-less printks to pr_* Mitchel Humpherys
2014-03-31 18:35 ` Christoph Lameter
2014-03-31 18:44 ` Joe Perches
2014-04-03 16:33 ` Christoph Lameter [this message]
2014-04-03 16:57 ` Mitchel Humpherys
2014-04-14 22:55 ` Andrew Morton
2014-04-15 23:58 ` Mitchel Humpherys
2014-04-16 0:05 ` Mitchel Humpherys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1404031132310.21658@nuc \
--to=cl@linux.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mitchelh@codeaurora.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox