From: Christoph Lameter <cl@linux.com>
To: Mitchel Humpherys <mitchelh@codeaurora.org>
Cc: Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: convert some level-less printks to pr_*
Date: Thu, 27 Mar 2014 11:10:53 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1403271110010.10482@nuc> (raw)
In-Reply-To: <alpine.DEB.2.10.1403261938160.5585@nuc>
Would like to retracting the ack after seeing the other comments. Will ack
after then issues have been fixed.
On Wed, 26 Mar 2014, Christoph Lameter wrote:
> On Wed, 26 Mar 2014, Mitchel Humpherys wrote:
>
> > printk is meant to be used with an associated log level. There are some
> > instances of printk scattered around the mm code where the log level is
> > missing. Add a log level and adhere to suggestions by
> > scripts/checkpatch.pl by moving to the pr_* macros.
>
> Acked-by: Christoph Lameter <cl@linux.com>
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-03-27 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 23:49 [PATCH] Some printk cleanup in mm Mitchel Humpherys
2014-03-26 23:49 ` [PATCH] mm: convert some level-less printks to pr_* Mitchel Humpherys
2014-03-27 0:07 ` Joe Perches
2014-03-27 0:38 ` Christoph Lameter
2014-03-27 16:10 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1403271110010.10482@nuc \
--to=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mitchelh@codeaurora.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox