linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild test robot <fengguang.wu@intel.com>,
	Sasha Levin <sasha.levin@oracle.com>,
	kbuild-all@01.org, linux-kernel@vger.kernel.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	David Vrabel <david.vrabel@citrix.com>,
	boris.ostrovsky@oracle.com
Subject: Re: arch/x86/xen/suspend.c:70:9: error: implicit declaration of function 'xen_pv_domain'
Date: Tue, 22 Dec 2015 11:49:46 +0000	[thread overview]
Message-ID: <alpine.DEB.2.02.1512221142200.3096@kaball.uk.xensource.com> (raw)
In-Reply-To: <20151221140704.e376871cd786498eb5e71352@linux-foundation.org>

On Mon, 21 Dec 2015, Andrew Morton wrote:
> On Mon, 21 Dec 2015 00:43:17 +0800 kbuild test robot <fengguang.wu@intel.com> wrote:
> 
> > First bad commit (maybe != root cause):
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head:   69c37a92ddbf79d9672230f21a04580d7ac2f4c3
> > commit: 71458cfc782eafe4b27656e078d379a34e472adf kernel: add support for gcc 5
> > date:   1 year, 2 months ago
> > config: x86_64-randconfig-x006-201551 (attached as .config)
> > reproduce:
> >         git checkout 71458cfc782eafe4b27656e078d379a34e472adf
> >         # save the attached .config to linux build tree
> >         make ARCH=x86_64 
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    arch/x86/xen/suspend.c: In function 'xen_arch_pre_suspend':
> > >> arch/x86/xen/suspend.c:70:9: error: implicit declaration of function 'xen_pv_domain' [-Werror=implicit-function-declaration]
> >         if (xen_pv_domain())
> >             ^
> 
> hm, tricky!
> 
> --- a/arch/x86/xen/suspend.c~arch-x86-xen-suspendc-include-xen-xenh
> +++ a/arch/x86/xen/suspend.c
> @@ -1,6 +1,7 @@
>  #include <linux/types.h>
>  #include <linux/tick.h>
>  
> +#include <xen/xen.h>
>  #include <xen/interface/xen.h>
>  #include <xen/grant_table.h>
>  #include <xen/events.h>


Looks like the right fix. David? Boris?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-12-22 11:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-20 16:43 kbuild test robot
2015-12-21 22:07 ` Andrew Morton
2015-12-22 11:49   ` Stefano Stabellini [this message]
2015-12-22 14:31     ` Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1512221142200.3096@kaball.uk.xensource.com \
    --to=stefano.stabellini@eu.citrix.com \
    --cc=akpm@linux-foundation.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox