linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Zhang Zhen <zhenzhang.zhang@huawei.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org, wangnan0@huawei.com
Subject: Re: [PATCH] memory-hotplug: fix below build warning
Date: Wed, 10 Sep 2014 11:55:50 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.02.1409101153340.27173@chino.kir.corp.google.com> (raw)
In-Reply-To: <1410228703-2496-1-git-send-email-zhenzhang.zhang@huawei.com>

On Tue, 9 Sep 2014, Zhang Zhen wrote:

> drivers/base/memory.c: In function 'show_valid_zones':
> drivers/base/memory.c:384:22: warning: unused variable 'zone_prev' [-Wunused-variable]
>   struct zone *zone, *zone_prev;
>                       ^
> 
> Signed-off-by: Zhang Zhen <zhenzhang.zhang@huawei.com>

This is
Reported-by: kbuild test robot <fengguang.wu@intel.com>
on August 29 to this mailing list.

> ---
>  drivers/base/memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index efd456c..7c5d871 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -381,7 +381,7 @@ static ssize_t show_valid_zones(struct device *dev,
>  	unsigned long start_pfn, end_pfn;
>  	unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block;
>  	struct page *first_page;
> -	struct zone *zone, *zone_prev;
> +	struct zone *zone;
>  
>  	start_pfn = section_nr_to_pfn(mem->start_section_nr);
>  	end_pfn = start_pfn + nr_pages;

Looks good, but this should already be fixed by
http://ozlabs.org/~akpm/mmotm/broken-out/memory-hotplug-add-sysfs-zones_online_to-attribute-fix-3-fix.patch
right?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-09-10 18:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09  2:11 Zhang Zhen
2014-09-10 18:55 ` David Rientjes [this message]
2014-09-11  1:07   ` Zhang Zhen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1409101153340.27173@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=wangnan0@huawei.com \
    --cc=zhenzhang.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox