From: David Rientjes <rientjes@google.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <tj@kernel.org>, Li Zefan <lizefan@huawei.com>,
Michal Hocko <mhocko@suse.cz>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch v2] mm, hugetlb_cgroup: align hugetlb cgroup limit to hugepage size
Date: Sat, 9 Aug 2014 14:34:46 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1408091434280.17896@chino.kir.corp.google.com> (raw)
In-Reply-To: <87mwbem0zo.fsf@linux.vnet.ibm.com>
On Sat, 9 Aug 2014, Aneesh Kumar K.V wrote:
> > diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> > --- a/mm/hugetlb_cgroup.c
> > +++ b/mm/hugetlb_cgroup.c
> > @@ -275,6 +275,7 @@ static ssize_t hugetlb_cgroup_write(struct kernfs_open_file *of,
> > ret = res_counter_memparse_write_strategy(buf, &val);
> > if (ret)
> > break;
> > + val = ALIGN(val, 1ULL << huge_page_shift(&hstates[idx]));
>
> Do we really need ULL ? max value should fit in unsigned long right ?
>
I usually just go for type agreement.
> > ret = res_counter_set_limit(&h_cg->hugepage[idx], val);
> > break;
> > default:
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-08-09 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 20:34 [patch] " David Rientjes
2014-08-08 5:47 ` Aneesh Kumar K.V
2014-08-08 8:21 ` Michal Hocko
2014-08-08 22:07 ` [patch v2] " David Rientjes
2014-08-09 10:05 ` Aneesh Kumar K.V
2014-08-09 21:34 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1408091434280.17896@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan@huawei.com \
--cc=mhocko@suse.cz \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox