* Re: [next:master 9660/12021] mm/vmstat.c:1343:2-5: WARNING: Use BUG_ON
[not found] <53e5eeb3.j/1hw4T//eDPmwb+%fengguang.wu@intel.com>
@ 2014-08-09 11:31 ` Julia Lawall
2014-08-11 17:17 ` Christoph Lameter
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2014-08-09 11:31 UTC (permalink / raw)
To: kbuild test robot; +Cc: kbuild, cl, akpm, linux-mm
I suspect that using BUG_ON here is not a good idea, because the tested
called function looks pretty important. But I have forwarded it on in
case someone thinks otherwise.
julia
On Sat, 9 Aug 2014, kbuild test robot wrote:
> TO: Christoph Lameter <cl@linux-foundation.org>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: Linux Memory Management List <linux-mm@kvack.org>
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 6a062ecb62b37d6d36fa2e56052982565b0f5aac
> commit: f9054025fb65d0802098f18b153e4d720acd126e [9660/12021] on demand vmstat: Do not open code alloc_cpumask_var
> :::::: branch date: 27 hours ago
> :::::: commit date: 9 days ago
>
> >> mm/vmstat.c:1343:2-5: WARNING: Use BUG_ON
>
> Please consider folding the attached diff :-)
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [next:master 9660/12021] mm/vmstat.c:1343:2-5: WARNING: Use BUG_ON
2014-08-09 11:31 ` [next:master 9660/12021] mm/vmstat.c:1343:2-5: WARNING: Use BUG_ON Julia Lawall
@ 2014-08-11 17:17 ` Christoph Lameter
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Lameter @ 2014-08-11 17:17 UTC (permalink / raw)
To: Julia Lawall; +Cc: kbuild test robot, kbuild, akpm, linux-mm
On Sat, 9 Aug 2014, Julia Lawall wrote:
> I suspect that using BUG_ON here is not a good idea, because the tested
> called function looks pretty important. But I have forwarded it on in
> case someone thinks otherwise.
BUG_ON is not a good idea here because the function does essential
allocation and is not just a function that checks for certain error
condition.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-11 17:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <53e5eeb3.j/1hw4T//eDPmwb+%fengguang.wu@intel.com>
2014-08-09 11:31 ` [next:master 9660/12021] mm/vmstat.c:1343:2-5: WARNING: Use BUG_ON Julia Lawall
2014-08-11 17:17 ` Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox