From: David Rientjes <rientjes@google.com>
To: Chintan Pandya <cpandya@codeaurora.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2] mm: BUG when __kmap_atomic_idx equals KM_TYPE_NR
Date: Thu, 31 Jul 2014 00:02:38 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1407310001360.18238@chino.kir.corp.google.com> (raw)
In-Reply-To: <1406787871-2951-1-git-send-email-cpandya@codeaurora.org>
On Thu, 31 Jul 2014, Chintan Pandya wrote:
> __kmap_atomic_idx is per_cpu variable. Each CPU can
> use KM_TYPE_NR entries from FIXMAP i.e. from 0 to
> KM_TYPE_NR - 1. Allowing __kmap_atomic_idx to over-
> shoot to KM_TYPE_NR can mess up with next CPU's 0th
> entry which is a bug. Hence BUG_ON if
> __kmap_atomic_idx >= KM_TYPE_NR.
>
This appears to be a completely different patch, not a v2. Why is this
check only done for CONFIG_DEBUG_HIGHMEM?
I think Andrew's comment earlier was referring to the changelog only and
not the patch, which looked correct.
> Signed-off-by: Chintan Pandya <cpandya@codeaurora.org>
> ---
> Changes:
>
> V1 --> V2
>
> Not touching CONFIG_DEBUG_HIGHMEM.
>
> include/linux/highmem.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/highmem.h b/include/linux/highmem.h
> index 7fb31da..9286a46 100644
> --- a/include/linux/highmem.h
> +++ b/include/linux/highmem.h
> @@ -93,7 +93,7 @@ static inline int kmap_atomic_idx_push(void)
>
> #ifdef CONFIG_DEBUG_HIGHMEM
> WARN_ON_ONCE(in_irq() && !irqs_disabled());
> - BUG_ON(idx > KM_TYPE_NR);
> + BUG_ON(idx >= KM_TYPE_NR);
> #endif
> return idx;
> }
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-07-31 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 6:24 Chintan Pandya
2014-07-31 7:02 ` David Rientjes [this message]
2014-07-31 9:28 ` Chintan Pandya
2014-07-31 22:45 ` Andrew Morton
2014-08-04 9:25 ` Chintan Pandya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1407310001360.18238@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cpandya@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox