linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Dave Hansen <dave.hansen@intel.com>,
	Andrey Ryabinin <a.ryabinin@samsung.com>,
	Sasha Levin <sasha.levin@oracle.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH 2/2] mm: mark fault_around_bytes __read_mostly
Date: Tue, 29 Jul 2014 15:38:16 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.02.1407291537350.20991@chino.kir.corp.google.com> (raw)
In-Reply-To: <1406633609-17586-3-git-send-email-kirill.shutemov@linux.intel.com>

On Tue, 29 Jul 2014, Kirill A. Shutemov wrote:

> fault_around_bytes can only be changed via debugfs. Let's mark it
> read-mostly.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

Suggested-by: David Rientjes <rientjes@google.com>
Acked-by: David Rientjes <rientjes@google.com>

> ---
>  mm/memory.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/memory.c b/mm/memory.c
> index 2ce07dc9b52b..ed3073d6a0e0 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -2768,7 +2768,8 @@ void do_set_pte(struct vm_area_struct *vma, unsigned long address,
>  	update_mmu_cache(vma, address, pte);
>  }
>  
> -static unsigned long fault_around_bytes = rounddown_pow_of_two(65536);
> +static unsigned long fault_around_bytes __read_mostly =
> +	rounddown_pow_of_two(65536);
>  
>  static inline unsigned long fault_around_pages(void)
>  {

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2014-07-29 22:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-29 11:33 [PATCH 0/2] faultaround updates Kirill A. Shutemov
2014-07-29 11:33 ` [PATCH 1/2] mm: close race between do_fault_around() and fault_around_bytes_set() Kirill A. Shutemov
2014-07-29 13:32   ` Andrey Ryabinin
2014-07-29 14:27     ` Kirill A. Shutemov
2014-07-29 17:07       ` Andrey Ryabinin
2014-07-29 22:36       ` David Rientjes
2014-07-29 23:16         ` Kirill A. Shutemov
2014-07-29 11:33 ` [PATCH 2/2] mm: mark fault_around_bytes __read_mostly Kirill A. Shutemov
2014-07-29 22:38   ` David Rientjes [this message]
2014-08-01 11:51 [PATCH 0/2] faultaround updates Kirill A. Shutemov
2014-08-01 11:51 ` [PATCH 2/2] mm: mark fault_around_bytes __read_mostly Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.02.1407291537350.20991@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=a.ryabinin@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=dave.hansen@intel.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-mm@kvack.org \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox