From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f174.google.com (mail-ie0-f174.google.com [209.85.223.174]) by kanga.kvack.org (Postfix) with ESMTP id 412C76B0036 for ; Tue, 29 Jul 2014 03:53:44 -0400 (EDT) Received: by mail-ie0-f174.google.com with SMTP id rp18so8232112iec.19 for ; Tue, 29 Jul 2014 00:53:44 -0700 (PDT) Received: from mail-ie0-x234.google.com (mail-ie0-x234.google.com [2607:f8b0:4001:c03::234]) by mx.google.com with ESMTPS id es17si46949975icb.12.2014.07.29.00.53.43 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 29 Jul 2014 00:53:43 -0700 (PDT) Received: by mail-ie0-f180.google.com with SMTP id at20so7880408iec.25 for ; Tue, 29 Jul 2014 00:53:43 -0700 (PDT) Date: Tue, 29 Jul 2014 00:53:41 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH v2] memory hotplug: update the variables after memory removed In-Reply-To: <53D74EE5.1070308@huawei.com> Message-ID: References: <1406619310-20555-1-git-send-email-zhenzhang.zhang@huawei.com> <53D74EE5.1070308@huawei.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Zhang Zhen Cc: Dave Hansen , mgorman@suse.de, Ingo Molnar , Andrew Morton , wangnan0@huawei.com, Linux MM , linux-kernel@vger.kernel.org On Tue, 29 Jul 2014, Zhang Zhen wrote: > Commit ea0854170c95245a258b386c7a9314399c949fe0 added a fuction This would normally be written as Commit ea0854170c95 ("memory hotplug: fix a bug on /dev/mem for 64-bit kernels") ... > update_end_of_memory_vars() to update high_memory, max_pfn and > max_low_pfn. > > I modified the function according to Dave Hansen and David Rientjes's > suggestions. > And call it in arch_remove_memory() to update these variables too. > When the x86 maintainers merge this patch, they'll need to make a judgment call on how urgent the fix is and that will guide them in whether they want it backported to stable kernels as well. It would be useful to provide the rationale for the change; in other words, why is the change needed and what breaks if we don't have it? > Change v1->v2: > - according to Dave Hansen and David Rientjes's suggestions modified > update_end_of_memory_vars(). > Signed-off-by: Zhang Zhen Acked-by: David Rientjes You'll want to email all the x86 maintainers who would handle this patch, check the output of scripts/get_maintainer.pl when run on this diff. > --- > arch/x86/mm/init_64.c | 23 ++++++++++++++--------- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > index df1a992..fd7bd6b 100644 > --- a/arch/x86/mm/init_64.c > +++ b/arch/x86/mm/init_64.c > @@ -673,15 +673,11 @@ void __init paging_init(void) > * After memory hotplug the variables max_pfn, max_low_pfn and high_memory need > * updating. > */ > -static void update_end_of_memory_vars(u64 start, u64 size) > +static void update_end_of_memory_vars(u64 end_pfn) Extra space that can be removed here at the same time as a cleanup. > { > - unsigned long end_pfn = PFN_UP(start + size); > - > - if (end_pfn > max_pfn) { > - max_pfn = end_pfn; > - max_low_pfn = end_pfn; > - high_memory = (void *)__va(max_pfn * PAGE_SIZE - 1) + 1; > - } > + max_pfn = end_pfn; > + max_low_pfn = end_pfn; > + high_memory = (void *)__va(max_pfn * PAGE_SIZE - 1) + 1; > } > > /* > @@ -694,6 +690,7 @@ int arch_add_memory(int nid, u64 start, u64 size) > struct zone *zone = pgdat->node_zones + ZONE_NORMAL; > unsigned long start_pfn = start >> PAGE_SHIFT; > unsigned long nr_pages = size >> PAGE_SHIFT; > + unsigned long end_pfn; > int ret; > > init_memory_mapping(start, start + size); > @@ -702,7 +699,9 @@ int arch_add_memory(int nid, u64 start, u64 size) > WARN_ON_ONCE(ret); > > /* update max_pfn, max_low_pfn and high_memory */ > - update_end_of_memory_vars(start, size); > + end_pfn = start_pfn + nr_pages; > + if (end_pfn > max_pfn) > + update_end_of_memory_vars(end_pfn); > > return ret; > } > @@ -1018,6 +1017,7 @@ int __ref arch_remove_memory(u64 start, u64 size) > unsigned long start_pfn = start >> PAGE_SHIFT; > unsigned long nr_pages = size >> PAGE_SHIFT; > struct zone *zone; > + unsigned long end_pfn; > int ret; > > zone = page_zone(pfn_to_page(start_pfn)); > @@ -1025,6 +1025,11 @@ int __ref arch_remove_memory(u64 start, u64 size) > ret = __remove_pages(zone, start_pfn, nr_pages); > WARN_ON_ONCE(ret); > > + /* update max_pfn, max_low_pfn and high_memory */ > + end_pfn = start_pfn + nr_pages; > + if ((max_pfn >= start_pfn) && (max_pfn < end_pfn)) > + update_end_of_memory_vars(start_pfn); Not sure if we really need the new variable here; if you choose to repropose this patch then you may want to consider just using start_pfn + nr_pages in the conditional. > + > return ret; > } > #endif -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org