From: David Rientjes <rientjes@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Rik van Riel <riel@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist
Date: Wed, 23 Jul 2014 18:16:32 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1407231815090.22326@chino.kir.corp.google.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1407231814110.22326@chino.kir.corp.google.com>
If the pagefault handler is modified to pass a non-NULL zonelist then an
unnecessary check for a NULL zonelist in constrained_alloc() can be removed.
Signed-off-by: David Rientjes <rientjes@google.com>
---
mm/oom_kill.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -208,8 +208,6 @@ static enum oom_constraint constrained_alloc(struct zonelist *zonelist,
/* Default to all available memory */
*totalpages = totalram_pages + total_swap_pages;
- if (!zonelist)
- return CONSTRAINT_NONE;
/*
* Reach here only when __GFP_NOFAIL is used. So, we should avoid
* to kill current.We have to random task kill in this case.
@@ -696,7 +694,7 @@ void pagefault_out_of_memory(void)
zonelist = node_zonelist(first_memory_node, GFP_KERNEL);
if (try_set_zonelist_oom(zonelist, GFP_KERNEL)) {
- out_of_memory(NULL, 0, 0, NULL, false);
+ out_of_memory(zonelist, 0, 0, NULL, false);
clear_zonelist_oom(zonelist, GFP_KERNEL);
}
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-07-24 1:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 1:16 [patch 1/3] mm, oom: ensure memoryless node zonelist always includes zones David Rientjes
2014-07-24 1:16 ` David Rientjes [this message]
2014-07-31 15:26 ` [patch 2/3] mm, oom: remove unnecessary check for NULL zonelist Johannes Weiner
2014-08-01 9:10 ` David Rientjes
2014-08-01 13:34 ` Johannes Weiner
2014-08-01 21:42 ` David Rientjes
2014-08-02 18:13 ` Johannes Weiner
2014-08-05 0:18 ` David Rientjes
2014-07-24 1:16 ` [patch 3/3] mm, oom: rename zonelist locking functions David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1407231815090.22326@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox