From: David Rientjes <rientjes@google.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: Will Woods <wwoods@redhat.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
kbuild-all@01.org
Subject: Re: arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared
Date: Wed, 18 Jun 2014 16:09:26 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1406181607490.22789@chino.kir.corp.google.com> (raw)
In-Reply-To: <53a21a3e.1HJ5drRU6UL26Oem%fengguang.wu@intel.com>
On Thu, 19 Jun 2014, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: e99cfa2d0634881b8a41d56c48b5956b9a3ba162
> commit: 1e2ee49f7f1b79f0b14884fe6a602f0411b39552 fanotify: fix -EOVERFLOW with large files on 64-bit
> date: 6 weeks ago
> config: make ARCH=ia64 allmodconfig
>
> All error/warnings:
>
> fs/notify/fanotify/fanotify_user.c: In function 'SYSC_fanotify_init':
> fs/notify/fanotify/fanotify_user.c:701:2: error: implicit declaration of function 'personality' [-Werror=implicit-function-declaration]
> if (force_o_largefile())
> ^
> In file included from include/uapi/linux/fcntl.h:4:0,
> from include/linux/fcntl.h:4,
> from fs/notify/fanotify/fanotify_user.c:2:
> >> arch/ia64/include/uapi/asm/fcntl.h:9:41: error: 'PER_LINUX32' undeclared (first use in this function)
> (personality(current->personality) != PER_LINUX32)
> ^
> fs/notify/fanotify/fanotify_user.c:701:6: note: in expansion of macro 'force_o_largefile'
> if (force_o_largefile())
> ^
> arch/ia64/include/uapi/asm/fcntl.h:9:41: note: each undeclared identifier is reported only once for each function it appears in
> (personality(current->personality) != PER_LINUX32)
> ^
> fs/notify/fanotify/fanotify_user.c:701:6: note: in expansion of macro 'force_o_largefile'
> if (force_o_largefile())
> ^
> cc1: some warnings being treated as errors
>
I think this wants to add #include <linux/personality.h> to
arch/ia64/include/uapi/asm/fcntl.h. I don't think we should be adding it
to fs/notify/fanotify/fanotify_user.c if
arch/ia64/include/uapi/asm/fcntl.h strictly requires it.
Yay for build errors reported six weeks later and after 3.15 had been
released.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-06-18 23:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 23:01 kbuild test robot
2014-06-18 23:09 ` David Rientjes [this message]
2014-06-18 23:30 ` Andrew Morton
2014-06-19 16:25 ` Tony Luck
2014-06-19 18:13 ` Andrew Morton
2014-06-18 23:20 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1406181607490.22789@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
--cc=wwoods@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox