From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) by kanga.kvack.org (Postfix) with ESMTP id 23B0F6B00B4 for ; Mon, 9 Jun 2014 17:57:19 -0400 (EDT) Received: by mail-ig0-f171.google.com with SMTP id h18so914644igc.10 for ; Mon, 09 Jun 2014 14:57:19 -0700 (PDT) Received: from mail-ie0-x230.google.com (mail-ie0-x230.google.com [2607:f8b0:4001:c03::230]) by mx.google.com with ESMTPS id h5si39807224igt.51.2014.06.09.14.57.18 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 09 Jun 2014 14:57:18 -0700 (PDT) Received: by mail-ie0-f176.google.com with SMTP id rl12so6369711iec.21 for ; Mon, 09 Jun 2014 14:57:18 -0700 (PDT) Date: Mon, 9 Jun 2014 14:57:16 -0700 (PDT) From: David Rientjes Subject: Re: [PATCH] x86: numa: drop ZONE_ALIGN In-Reply-To: <20140609144355.63a91968@redhat.com> Message-ID: References: <20140608181436.17de69ac@redhat.com> <20140609144355.63a91968@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Luiz Capitulino Cc: akpm@linux-foundation.org, andi@firstfloor.org, riel@redhat.com, yinghai@kernel.org, isimatu.yasuaki@jp.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org On Mon, 9 Jun 2014, Luiz Capitulino wrote: > > > diff --git a/arch/x86/include/asm/numa.h b/arch/x86/include/asm/numa.h > > > index 4064aca..01b493e 100644 > > > --- a/arch/x86/include/asm/numa.h > > > +++ b/arch/x86/include/asm/numa.h > > > @@ -9,7 +9,6 @@ > > > #ifdef CONFIG_NUMA > > > > > > #define NR_NODE_MEMBLKS (MAX_NUMNODES*2) > > > -#define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) > > > > > > /* > > > * Too small node sizes may confuse the VM badly. Usually they > > > diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c > > > index 1d045f9..69f6362 100644 > > > --- a/arch/x86/mm/numa.c > > > +++ b/arch/x86/mm/numa.c > > > @@ -200,8 +200,6 @@ static void __init setup_node_data(int nid, u64 start, u64 end) > > > if (end && (end - start) < NODE_MIN_SIZE) > > > return; > > > > > > - start = roundup(start, ZONE_ALIGN); > > > - > > > printk(KERN_INFO "Initmem setup node %d [mem %#010Lx-%#010Lx]\n", > > > nid, start, end - 1); > > > > > > > What ensures this start address is page aligned from the BIOS? > > To which start address do you refer to? The start address displayed in the dmesg is not page aligned anymore with your change, correct? acpi_parse_memory_affinity() does no transformations on the table, the base address is coming strictly from the SRAT and there is no page alignment requirement in the ACPI specification. NODE_DATA(nid)->node_start_pfn will be correct because it does the shift for you, but it still seems you want to at least align to PAGE_SIZE here. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org