From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by kanga.kvack.org (Postfix) with ESMTP id 556CA6B009B for ; Wed, 4 Jun 2014 20:13:47 -0400 (EDT) Received: by mail-ie0-f180.google.com with SMTP id at20so39138iec.39 for ; Wed, 04 Jun 2014 17:13:47 -0700 (PDT) Received: from mail-ig0-x233.google.com (mail-ig0-x233.google.com [2607:f8b0:4001:c05::233]) by mx.google.com with ESMTPS id d7si8652768ico.17.2014.06.04.17.13.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 04 Jun 2014 17:13:46 -0700 (PDT) Received: by mail-ig0-f179.google.com with SMTP id hn18so1717902igb.6 for ; Wed, 04 Jun 2014 17:13:46 -0700 (PDT) Date: Wed, 4 Jun 2014 17:13:44 -0700 (PDT) From: David Rientjes Subject: Re: [RESEND PATCH] slub: search partial list on numa_mem_id(), instead of numa_node_id() In-Reply-To: <1391674026-20092-1-git-send-email-iamjoonsoo.kim@lge.com> Message-ID: References: <20140206020757.GC5433@linux.vnet.ibm.com> <1391674026-20092-1-git-send-email-iamjoonsoo.kim@lge.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Andrew Morton Cc: Joonsoo Kim , Nishanth Aravamudan , Pekka Enberg , Christoph Lameter , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim , Han Pingtian , paulus@samba.org, Anton Blanchard , mpm@selenic.com, linuxppc-dev@lists.ozlabs.org, Wanpeng Li On Wed, 21 May 2014, Joonsoo Kim wrote: > Currently, if allocation constraint to node is NUMA_NO_NODE, we search > a partial slab on numa_node_id() node. This doesn't work properly on the > system having memoryless node, since it can have no memory on that node and > there must be no partial slab on that node. > > On that node, page allocation always fallback to numa_mem_id() first. So > searching a partial slab on numa_node_id() in that case is proper solution > for memoryless node case. > > Acked-by: Nishanth Aravamudan > Acked-by: David Rientjes > Acked-by: Christoph Lameter > Signed-off-by: Joonsoo Kim > > diff --git a/mm/slub.c b/mm/slub.c > index 545a170..cc1f995 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1698,7 +1698,7 @@ static void *get_partial(struct kmem_cache *s, gfp_t flags, int node, > struct kmem_cache_cpu *c) > { > void *object; > - int searchnode = (node == NUMA_NO_NODE) ? numa_node_id() : node; > + int searchnode = (node == NUMA_NO_NODE) ? numa_mem_id() : node; > > object = get_partial_node(s, get_node(s, searchnode), c, flags); > if (object || node != NUMA_NO_NODE) Andrew, can you merge this please? It's still not in linux-next. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org