From: David Rientjes <rientjes@google.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Pekka Enberg <penberg@kernel.org>,
Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Joonsoo Kim <js1304@gmail.com>
Subject: Re: [PATCH v2 04/10] slab: defer slab_destroy in free_block()
Date: Wed, 7 May 2014 18:01:50 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1405071801040.1128@chino.kir.corp.google.com> (raw)
In-Reply-To: <1399442780-28748-5-git-send-email-iamjoonsoo.kim@lge.com>
On Wed, 7 May 2014, Joonsoo Kim wrote:
> In free_block(), if freeing object makes new free slab and number of
> free_objects exceeds free_limit, we start to destroy this new free slab
> with holding the kmem_cache node lock. Holding the lock is useless and,
> generally, holding a lock as least as possible is good thing. I never
> measure performance effect of this, but we'd be better not to hold the lock
> as much as possible.
>
> Commented by Christoph:
> This is also good because kmem_cache_free is no longer called while
> holding the node lock. So we avoid one case of recursion.
>
> Acked-by: Christoph Lameter <cl@linux.com>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Acked-by: David Rientjes <rientjes@google.com>
Nice optimization. I think it could have benefited from a comment
describing what the free_block() list formal is, though.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-05-08 1:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 6:06 [PATCH v2 00/10] clean-up and remove lockdep annotation in SLAB Joonsoo Kim
2014-05-07 6:06 ` [PATCH v2 01/10] slab: add unlikely macro to help compiler Joonsoo Kim
2014-05-07 14:21 ` Christoph Lameter
2014-05-07 6:06 ` [PATCH v2 02/10] slab: makes clear_obj_pfmemalloc() just return masked value Joonsoo Kim
2014-05-07 14:22 ` Christoph Lameter
2014-05-07 6:06 ` [PATCH v2 03/10] slab: move up code to get kmem_cache_node in free_block() Joonsoo Kim
2014-05-08 0:52 ` David Rientjes
2014-05-07 6:06 ` [PATCH v2 04/10] slab: defer slab_destroy " Joonsoo Kim
2014-05-08 1:01 ` David Rientjes [this message]
2014-05-07 6:06 ` [PATCH v2 05/10] slab: factor out initialization of arracy cache Joonsoo Kim
2014-05-08 1:19 ` David Rientjes
2014-05-07 6:06 ` [PATCH v2 06/10] slab: introduce alien_cache Joonsoo Kim
2014-05-07 6:06 ` [PATCH v2 07/10] slab: use the lock on alien_cache, instead of the lock on array_cache Joonsoo Kim
2014-05-07 6:06 ` [PATCH v2 08/10] slab: destroy a slab without holding any alien cache lock Joonsoo Kim
2014-05-07 6:06 ` [PATCH v2 09/10] slab: remove a useless lockdep annotation Joonsoo Kim
2014-05-07 14:25 ` Christoph Lameter
2014-05-07 6:06 ` [PATCH v2 10/10] slab: remove BAD_ALIEN_MAGIC Joonsoo Kim
2014-05-07 14:24 ` Christoph Lameter
2014-05-21 7:43 ` [PATCH v2 00/10] clean-up and remove lockdep annotation in SLAB Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1405071801040.1128@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox