From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by kanga.kvack.org (Postfix) with ESMTP id 0DC4E6B0031 for ; Fri, 7 Feb 2014 16:04:50 -0500 (EST) Received: by mail-pd0-f179.google.com with SMTP id fp1so3249569pdb.38 for ; Fri, 07 Feb 2014 13:04:50 -0800 (PST) Received: from mail-pa0-x22a.google.com (mail-pa0-x22a.google.com [2607:f8b0:400e:c03::22a]) by mx.google.com with ESMTPS id q5si6311610pae.346.2014.02.07.13.04.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 07 Feb 2014 13:04:50 -0800 (PST) Received: by mail-pa0-f42.google.com with SMTP id kl14so3689021pab.15 for ; Fri, 07 Feb 2014 13:04:49 -0800 (PST) Date: Fri, 7 Feb 2014 13:04:47 -0800 (PST) From: David Rientjes Subject: Re: [PATCH 9/9] mm: Remove ifdef condition in include/linux/mm.h In-Reply-To: <63adb3b97f2869d4c7e76d17ef4aa76b8cf599f3.1391167128.git.rashika.kheria@gmail.com> Message-ID: References: <63adb3b97f2869d4c7e76d17ef4aa76b8cf599f3.1391167128.git.rashika.kheria@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Rashika Kheria Cc: linux-kernel@vger.kernel.org, Andrew Morton , Rik van Riel , "Kirill A. Shutemov" , Jiang Liu , Michel Lespinasse , linux-mm@kvack.org, josh@joshtriplett.org On Fri, 7 Feb 2014, Rashika Kheria wrote: > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 1cedd00..5f8348f 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -1589,10 +1589,8 @@ static inline int __early_pfn_to_nid(unsigned long pfn) > #else > /* please see mm/page_alloc.c */ > extern int __meminit early_pfn_to_nid(unsigned long pfn); > -#ifdef CONFIG_HAVE_ARCH_EARLY_PFN_TO_NID > /* there is a per-arch backend function. */ > extern int __meminit __early_pfn_to_nid(unsigned long pfn); > -#endif /* CONFIG_HAVE_ARCH_EARLY_PFN_TO_NID */ > #endif > > extern void set_dma_reserve(unsigned long new_dma_reserve); Wouldn't it be better to just declare the __early_pfn_to_nid() in mm/page_alloc.c to be static? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org