From: David Rientjes <rientjes@google.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: Davidlohr Bueso <davidlohr@hp.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill@shutemov.name>,
Jonathan Gonzalez <jgonzalez@linets.cl>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm, hugetlb: gimme back my page
Date: Thu, 30 Jan 2014 12:58:00 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.02.1401301256540.15271@chino.kir.corp.google.com> (raw)
In-Reply-To: <52EA57AC.3090700@oracle.com>
On Thu, 30 Jan 2014, Sasha Levin wrote:
> VM_BUG_ON_PAGE is just a VM_BUG_ON that does dump_page before the BUG().
>
> The only reason to use VM_BUG_ON instead of VM_BUG_ON_PAGE is if the page
> you're working
> with doesn't make sense/isn't useful as debug output.
>
> If doing a dump_page is causing issues somewhere then dump_pages should be
> fixed - instead
> of hiding the problem under the rug by not using it.
>
It sounds like dump_page() isn't necessarily at fault itself but rather
that using it is opening a race even wider that causes this failure to
occur more often than it normally would.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-01-30 20:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 6:37 Davidlohr Bueso
2014-01-30 9:59 ` Michal Hocko
2014-01-30 17:15 ` Davidlohr Bueso
2014-01-30 13:46 ` Sasha Levin
2014-01-30 20:58 ` David Rientjes [this message]
2014-01-31 17:50 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1401301256540.15271@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=davidlohr@hp.com \
--cc=jgonzalez@linets.cl \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox